Control: tags -1 + moreinfo Marc,
Preamble...
Thank you for taking the time to create this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help
package submitters to Debian mentors inorder to improve their packages
prior to possible sponsorship into Debian. There is no obligation on behalf
of the submitter to make any alterations based upon information provided
in the review.
Review...
1. Build[1]: Good
2. Lintian[2]: Information
I: openvpn3-client: typo-in-manual-page "allows to" "allows one to"
[usr/share/man/man1/openvpn3-config-manage.1.gz:41]
N:
N: Lintian found a spelling error in a manual page. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary
like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help
of
N: gettext (with the help of po4a, for example) or a similar tool, please
fix
N: the error in the translations as well as the English text to avoid
making
N: the translations fuzzy. With gettext, for example, this means you should
N: also fix the spelling mistake in the corresponding msgids in the *.po
N: files.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: spelling-error-in-manpage
3. Licenses (lrc[3]): Issue
A few to look at and verify.
AGPL-3+ | BSL-1.0 openvpn3-core/deps/vcpkg-
ports/asio/vcpkg.json
AGPL-3+ | GPL-3 openvpn3-
core/openvpn/asio/asioresolverres.hpp
AGPL-3+ | Unicode-DFS-2015 openvpn3-core/openvpn/common/unicode-
impl.hpp
AGPL-3+ | GPL-3 openvpn3-
core/openvpn/crypto/tls_crypt_v2.hpp
AGPL-3+ | GPL-3 openvpn3-core/openvpn/mbedtls/util/pem.hpp
AGPL-3+ | APSL-2.0 and/or BSD-4-Clause-UC openvpn3-
core/openvpn/netconf/ios/net-route.h
AGPL-3+ | GPL-3 openvpn3-core/openvpn/openssl/util/pem.hpp
4. Watch file (uscan --force-download):
5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good
6. Reproducible builds (reporotest)[3]: Good
7. Install (No previous installs): Good
8. Upgrade (Over previous installs if any): N/A
Additional...
A. Please update 'Standards-Version' in 'debian/control' to 4.7.0 as per
Debian policy[5].
Summary...
I believe openvpn3-client is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.
Regards
Phil
[1] Using:
* pbuilder - https://wiki.ubuntu.com/PbuilderHowto.
* https://wiki.debian.org/PbuilderTricks
and
* sbuild - https://wiki.debian.org/sbuild.
[2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different, so be thorough.
[3] 'lrc' from 'licenserecon' is located in Debian testing and newer.
[4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
[5] https://www.debian.org/doc/debian-policy/
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
--
signature.asc
Description: This is a digitally signed message part
