Control: tags -1 + moreinfo Julius,
Preamble...
Thank you for taking the time to create this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help
package submitters to Debian mentors inorder to improve their packages
prior to possible sponsorship into Debian. There is no obligation on behalf
of the submitter to make any alterations based upon information provided
in the review.
Review...
1. Build[1]: Good
2. Lintian[2]: Good
Note:
A couple of speeling issues in bianry that can be worked on for a future
release.
I: libopen62541-1.4: spelling-error-in-binary Mutiple Multiple
[usr/lib/x86_64-linux-gnu/libopen62541.so.1.4.2]
N:
N: Lintian found a spelling error in the given binary. Lintian has a list
of
N: common misspellings that it looks for. It does not have a dictionary
like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help
of
N: gettext or a similar tool, please fix the error in the translations as
N: well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling
mistake
N: in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/spelling
N:
N:
I: libopen62541-1.4: spelling-error-in-binary explicity explicitly
[usr/lib/x86_64-linux-gnu/libopen62541.so.1.4.2]
3. Licenses (lrc[3]): Good
4. Watch file (uscan --force-download): Good
5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good
6. Reproducible builds (reporotest)[3]: Good
7. Install (No previous installs): Good
8. Upgrade (Over previous installs if any): N/A
Additional...
A. Please update 'Standards-Version' in 'debian/control' to latest 4.7.0 as
per Debian policy[5].
B. You can remove 'debhelper (>= 13)' and add 'debhelper-compat (= 13)' in
'debian/control', then remove 'debian/compat'. Use of a 'compat' file is no
longer the Debian way.
Summary...
I believe open62541 is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.
Regards
Phil
[1] Using:
* pbuilder - https://wiki.ubuntu.com/PbuilderHowto.
* https://wiki.debian.org/PbuilderTricks
and
* sbuild - https://wiki.debian.org/sbuild.
[2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different, so be thorough.
[3] 'lrc' from 'licenserecon' is located in Debian testing and newer.
[4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
[5] https://www.debian.org/doc/debian-policy/
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
--
signature.asc
Description: This is a digitally signed message part
