Hi, On Fri, 19 Jul 2024 12:41:54 +0000 =?UTF-8?Q?G=C3=A1bor_N=C3=A9meth?= <ho...@riseup.net> wrote: > Phil, > > I've prepared a new submission at mentors [1] and believe all the issues > were addressed: > > - A new upstream & corresponding changes in d/ clear up the licenses > (BTW thanks for mentioning `lrc` which I did not know about earlier; > it still complains about a few files that > have either "and" or "or" dual licensing but I believe d/copyright is > now correct) > - Both `pbuild --twice` and `reportest` finish without an error for me > - As does lintian: hardening was added to the build, and overrides for > false positives are now recorded > > Would you be so kind as to take a look? > > [1] > https://mentors.debian.net/debian/pool/main/m/msc-generator/msc-generator_8.6.2-1.dsc
I think all changes look okay except for adding the usage of dpkg-vendor and exporting a specific environment variable only on Debian in debian/rules. Could you please explain it? A Debian-specific behavior will cause implicit behavior difference between Debian and downstream distributions, and is usually avoided unless you have a good justification. Once I receive a good explanation on it, I can sponsor and upload your package. Thanks, Boyuan Yang
signature.asc
Description: This is a digitally signed message part
