Control: tags -1 + moreinfo Gabor,
Preamble... Thank you for taking the time to create this package and your contribution to the Debian project. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build[1]: Good 2. Lintian[2]: Issue I: msc-generator: hardening-no-bindnow [usr/bin/msc-gen] N: N: This package provides an ELF binary that lacks the "bindnow" linker flag. N: N: This is needed (together with "relro") to make the "Global Offset Table" N: (GOT) fully read-only. The bindnow feature trades startup time for N: improved security. Please consider enabling this feature or consider N: overriding the tag (possibly with a comment about why). N: N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or N: hardening=+all to DEB_BUILD_MAINT_OPTIONS. N: N: The relevant compiler flags are set in LDFLAGS. N: N: Please refer to https://wiki.debian.org/Hardening for details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: msc-generator-nox: hardening-no-bindnow [usr/bin/msc-gen] I: msc-generator source: repackaged-source-not-advertised [debian/copyright] N: N: The debian/copyright file mentions Files-Excluded but the source version N: has no repack suffix. N: N: Repackaged sources are expected to indicate in their version number that N: they are different from the upstream release. It is commonly done by N: adding a repack suffix to the upstream version. N: N: The choice of repack suffix depends on the reason for repackaging. When N: some files were excluded because licensing was a concern, the suffix +dfsg N: may be appropriate. In more generic cases, one could chose +ds. N: N: Upstream sources are sometimes repackaged by accident when using old N: versions of dh_make. It can also happen when a maintainer invokes the N: dh_make option --createorig even though it is not needed. N: N: According to the Debian Developer's Reference 6.7.8.2, the repack suffix N: is not required. N: N: Please include such a suffix in the changelog version number to avoid this N: warning. N: N: Please refer to Bug#471537 and N: https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html N: for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/copyright/dep5 I: msc-generator: spelling-error-in-binary betweeen between [usr/bin/msc-gen] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling 3. Licenses (lrc): Issue Possible license issues. philwyett@ks-windu:~/Development/builder/debian/mentoring/msc-generator-8.6.1$ lrc en: Versions: recon 1.11 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck Affero | GFDL-1.2+ doc/msc-gen.texi Affero | GPL-3+ doc/texinfo.tex MIT | Expat src/imported/file_dialog/ImGuiFileDialog.cpp MIT | Expat src/imported/file_dialog/ImGuiFileDialog.h MIT | Unlicense src/imported/imgui/backends/imgui_impl_opengl3_loader.h MIT | Expat and/or Unlicense src/imported/imgui/imstb_rectpack.h MIT | Expat and/or Unlicense src/imported/imgui/imstb_textedit.h MIT | Expat and/or Unlicense src/imported/imgui/imstb_truetype.h Affero | Expat src/imported/miniz/miniz.c Affero | AGPL-3+ src/libblock/block_arrows.cpp Affero | AGPL-3+ src/libblock/block_arrows.h Affero | AGPL-3+ src/libblock/block_blocks.cpp Affero | AGPL-3+ src/libblock/block_blocks.h Affero | AGPL-3+ src/libblock/blockchart.cpp Affero | AGPL-3+ src/libblock/blockchart.h Affero | AGPL-3+ src/libblock/blockcsh.cpp Affero | AGPL-3+ src/libblock/blockcsh.h Affero | AGPL-3+ src/libblock/block_lang.yy Affero | GPL-3+ with Bison-2.2 exception src/libblock/block_parser_compile.h Affero | GPL-3+ with Bison-2.2 exception src/libblock/block_parser_csh.h Affero | AGPL-3+ src/libblock/blockstyle.cpp Affero | AGPL-3+ src/libblock/blockstyle.h Affero | AGPL-3+ src/libcgencommon/area.cpp Affero | AGPL-3+ src/libcgencommon/area.h Affero | AGPL-3+ src/libcgencommon/canvas.cpp Affero | AGPL-3+ src/libcgencommon/canvas.h Affero | AGPL-3+ src/libcgencommon/cgen_arrowhead.cpp Affero | AGPL-3+ src/libcgencommon/cgen_arrowhead.h Affero | AGPL-3+ src/libcgencommon/cgen_attribute.cpp Affero | AGPL-3+ src/libcgencommon/cgen_attribute.h Affero | AGPL-3+ src/libcgencommon/cgen_color.cpp Affero | AGPL-3+ src/libcgencommon/cgen_color.h Affero | AGPL-3+ src/libcgencommon/cgencommon.cpp Affero | AGPL-3+ src/libcgencommon/cgencommon.h Affero | AGPL-3+ src/libcgencommon/cgen_context.cpp Affero | AGPL-3+ src/libcgencommon/cgen_context.h Affero | AGPL-3+ src/libcgencommon/cgen_progress.h Affero | AGPL-3+ src/libcgencommon/cgen_shapes.cpp Affero | AGPL-3+ src/libcgencommon/cgen_shapes.h Affero | AGPL-3+ src/libcgencommon/chartbase.cpp Affero | AGPL-3+ src/libcgencommon/chartbase.h Affero | AGPL-3+ src/libcgencommon/commandline.cpp Affero | AGPL-3+ src/libcgencommon/commandline.h Affero | AGPL-3+ src/libcgencommon/contour_basics.h Affero | AGPL-3+ src/libcgencommon/contour.cpp Affero | AGPL-3+ src/libcgencommon/contour_debug.cpp Affero | AGPL-3+ src/libcgencommon/contour_debug.h Affero | AGPL-3+ and/or BSL-1.0 src/libcgencommon/contour_distance.cpp Affero | AGPL-3+ src/libcgencommon/contour_distance.h Affero | AGPL-3+ src/libcgencommon/contour_edge.cpp Affero | AGPL-3+ src/libcgencommon/contour_edge.h Affero | AGPL-3+ src/libcgencommon/contour.h Affero | AGPL-3+ src/libcgencommon/contour_path.h Affero | AGPL-3+ src/libcgencommon/contour_simple.cpp Affero | AGPL-3+ src/libcgencommon/contour_simple.h Affero | AGPL-3+ src/libcgencommon/csh.cpp Affero | AGPL-3+ src/libcgencommon/csh.h Affero | AGPL-3+ src/libcgencommon/element.cpp Affero | AGPL-3+ src/libcgencommon/element.h Affero | AGPL-3+ src/libcgencommon/error.cpp Affero | AGPL-3+ src/libcgencommon/error.h Affero | AGPL-3+ src/libcgencommon/numbering.cpp Affero | AGPL-3+ src/libcgencommon/numbering.h Affero | AGPL-3+ src/libcgencommon/stringparse.cpp Affero | AGPL-3+ src/libcgencommon/stringparse.h Affero | AGPL-3+ src/libcgencommon/style.cpp Affero | AGPL-3+ src/libcgencommon/style.h Affero | AGPL-3+ and/or Unicode-strict src/libcgencommon/utf8utils.cpp Affero | AGPL-3+ src/libcgencommon/utf8utils.h Affero | AGPL-3+ src/libdbg/dbgchart.cpp Affero | AGPL-3+ src/libdbg/dbgchart.h Affero | AGPL-3+ src/libflow/flowchart.cpp Affero | AGPL-3+ src/libflow/flowchart.h Affero | AGPL-3+ src/libflow/flowcsh.cpp Affero | AGPL-3+ src/libflow/flowcsh.h Affero | AGPL-3+ src/libflow/flow_lang.yy Affero | GPL-3+ with Bison-2.2 exception src/libflow/flow_parser_compile.h Affero | GPL-3+ with Bison-2.2 exception src/libflow/flow_parser_csh.h Affero | AGPL-3+ src/libflow/flowstyle.cpp Affero | AGPL-3+ src/libflow/flowstyle.h Affero | AGPL-3+ src/libflow/steps.cpp Affero | AGPL-3+ src/libflow/steps.h Affero | Expat src/libgui/text_editor_license.txt Affero | AGPL-3+ src/libgvgen/graphchart.cpp Affero | AGPL-3+ src/libgvgen/graphchart.h Affero | AGPL-3+ src/libgvgen/graph_lang.yy Affero | GPL-3+ with Bison-2.2 exception src/libgvgen/graph_parser_compile.h Affero | GPL-3+ with Bison-2.2 exception src/libgvgen/graph_parser_csh.h Affero | AGPL-3+ src/libgvgen/gvcsh.cpp Affero | AGPL-3+ src/libgvgen/gvcsh.h Affero | AGPL-3+ src/libgvgen/gvgraphs.cpp Affero | AGPL-3+ src/libgvgen/gvgraphs.h Affero | AGPL-3+ src/libgvgen/gv_lang_misc.h Affero | AGPL-3+ src/libgvgen/gvstyle.cpp Affero | AGPL-3+ src/libgvgen/gvstyle.h Affero | AGPL-3+ src/libmscgen/arcs.cpp Affero | AGPL-3+ src/libmscgen/arcs.h Affero | AGPL-3+ src/libmscgen/boxes.cpp Affero | AGPL-3+ src/libmscgen/boxes.h Affero | AGPL-3+ src/libmscgen/commands.cpp Affero | AGPL-3+ src/libmscgen/commands.h Affero | AGPL-3+ src/libmscgen/mscarrow.cpp Affero | AGPL-3+ src/libmscgen/mscarrow.h Affero | AGPL-3+ src/libmscgen/mscattribute.cpp Affero | AGPL-3+ src/libmscgen/mscattribute.h Affero | AGPL-3+ src/libmscgen/msc.cpp Affero | AGPL-3+ src/libmscgen/msccsh.cpp Affero | AGPL-3+ src/libmscgen/msccsh.h Affero | AGPL-3+ src/libmscgen/mscelement.cpp Affero | AGPL-3+ src/libmscgen/mscelement.h Affero | AGPL-3+ src/libmscgen/mscentity.cpp Affero | AGPL-3+ src/libmscgen/mscentity.h Affero | AGPL-3+ src/libmscgen/msc.h Affero | AGPL-3+ src/libmscgen/msc_lang.yy Affero | GPL-3+ with Bison-2.2 exception src/libmscgen/msc_parser_compile.h Affero | GPL-3+ with Bison-2.2 exception src/libmscgen/msc_parser_csh.h Affero | AGPL-3+ src/libmscgen/msc_parse_tools.cpp Affero | AGPL-3+ src/libmscgen/msc_parse_tools.h Affero | AGPL-3+ src/libmscgen/mscstyle.cpp Affero | AGPL-3+ src/libmscgen/mscstyle.h Affero | AGPL-3+ src/libxxx/xxxchart.cpp Affero | AGPL-3+ src/libxxx/xxxchart.h Affero | AGPL-3+ src/libxxx/xxxcsh.cpp Affero | AGPL-3+ src/libxxx/xxxcsh.h Affero | AGPL-3+ src/libxxx/xxx_lang.yy Affero | GPL-3+ with Bison-2.2 exception src/libxxx/xxx_parser_compile.h Affero | GPL-3+ with Bison-2.2 exception src/libxxx/xxx_parser_csh.h Affero | AGPL-3+ src/libxxx/xxxstyle.cpp Affero | AGPL-3+ src/libxxx/xxxstyle.h Affero | BSD-3-clause src/maphoon-lexer/acceptor.h Affero | BSD-3-clause src/maphoon-lexer/algorithms.h Affero | BSD-3-clause src/maphoon-lexer/classifier.h Affero | BSD-3-clause src/maphoon-lexer/deterministic.h Affero | BSD-3-clause src/maphoon-lexer/flatmap.h Affero | BSD-3-clause src/maphoon-lexer/generators.h Affero | BSD-3-clause src/maphoon-lexer/includes.h Affero | BSD-3-clause src/maphoon-lexer/indentation.h Affero | BSD-3-clause src/maphoon-lexer/minimization.h Affero | BSD-3-clause src/maphoon-lexer/minmax.h Affero | BSD-3-clause src/maphoon-lexer/partition.cpp Affero | BSD-3-clause src/maphoon-lexer/partition.h Affero | BSD-3-clause src/maphoon-lexer/reachableclasses.h Affero | BSD-3-clause src/maphoon-lexer/state.h Affero | BSD-3-clause src/maphoon-lexer/stateset.cpp Affero | BSD-3-clause src/maphoon-lexer/stateset.h Affero | AGPL-3+ tests/contour_test.cpp Affero | AGPL-3+ tests/contour_test.h 4. Watch file (uscan --force-download): 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Issue dpkg-source --before-build . debian/rules clean dh clean debian/rules execute_after_dh_auto_clean make[1]: Entering directory '/build/msc-generator-8.6.1' rm -rf /build/msc-generator-8.6.1/debian/build-gui /build/msc-generator- 8.6.1/debian/build-nox make[1]: Leaving directory '/build/msc-generator-8.6.1' dh_autoreconf_clean dh_clean cp: warning: behavior of -n is non-portable and may change in future; use -- update=none instead cp: warning: behavior of -n is non-portable and may change in future; use -- update=none instead dpkg-source -b . dpkg-source: info: using source format '3.0 (quilt)' dpkg-source: info: building msc-generator using existing ./msc- generator_8.6.1.orig.tar.xz dpkg-source: info: using patch list from debian/patches/series dpkg-source: warning: ignoring deletion of file Makefile.in, use --include- removal to override dpkg-source: warning: ignoring deletion of file tests/Makefile.in, use -- include-removal to override dpkg-source: info: local changes detected, the modified files are: msc-generator-8.6.1/doc/stamp-vti msc-generator-8.6.1/doc/version.texi dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree dpkg-source: info: you can integrate the local changes with dpkg-source --commit dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/msc- generator_8.6.1-1.diff.dBmY6I dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2 I: copying local configuration E: Failed autobuilding of package I: unmounting dev/ptmx filesystem 6. Reproducible builds (reporotest)[3]: Not performed at present 7. Install (No previous installs): Not performed at present 8. Upgrade (Over previous installs if any): Not performed at present Summary... I believe msc-generator is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. [1] Using pbuilder and sbuild. [2] lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different, so be thorough. [3] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method Regards Phil -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
signature.asc
Description: This is a digitally signed message part
