Hi, And thanks Phil for the first reviews!
On Sun, 07 Jul 2024 18:09:26 +0100 Phil Wyett <philip.wy...@kathenas.org> wrote:
> Evening Carmix, >> Thanks. You have done good work on the package and users will make good use of > the package in the future. hexwalk was in a curated list of packages I put > forward to the Debian devel mailing list requesting for DDs to look at, so
> here's hoping for sponsorship sooner rather than later. > I have some additional comments:- In d/changelog it is customary to let an empty line between the title line and the first item (I don't know if this is mandatory, though)
- Concerning licensing issues and d/copyright:* I cannot find an indication of the license in the package, outside of the debian/ directory. There should at least be the text of the license at the root, and headers with the copyright would be much appreciated in every source file. * Also I don't understand what is going on in src/src: there is the text of the LGPL-2.1 license. Who holds the copyright? Also it must be mentioned in d/copyright.
- d/control: Vcs-* fields must point to the VCS in which the Debian packaging is maintained. Currently there is no debian/ directory in the Github repo that is pointed by the fields. I suggest maintaining in Salsa and having a separate branch for the Debian packaging, as is done wiht the layout of git-buildpackage.
- debian/dirs can be removed, it is no more useful.- Please add a manual page, usually one expects to find a manpage for every command.
- Minor: some possible spelling errors are found by Lintian: "wtH" and "Higlighting".
Thanks for all the work on this, Cheers, -- Pierre
OpenPGP_signature.asc
Description: OpenPGP digital signature
