Control: tags -1 moreinfo Hi,
some review: d/control: - Please remove all versions from the versioned build depends that are fulfiled already since oldstable, e.g gettext and automake. - Your VCS-Git link git:// is not using an encrypted link, but the site supports https://. Please use https. d/copyright: - the directory lib/ has files which are not documented in d/copyright; (They have a different license and copyright) - same for the m4 macros embedded code copies: - gnulib is packaged for Debian, any reason why you don't use the packaged version? - there are m4 macros from autoconf-archive. Please check if you can use the ones from the package autoconf-archive. Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata d/changelog - d/changelog's purpose is to document changed to the packageing, generaly not to document upstream changes, so I'd cut that down to: trader (7.20-1) unstable; urgency=low * New upstream release. * Updated to Debian Policy 4.6.2 (no changes). - lintian findings: W: trader: groff-message troff:<standard input>:133: warning: macro 'mR' not defined [usr/share/man/man6/trader.6.gz:1] I: trader source: public-upstream-key-not-minimal has 16 extra signature(s) for keyid 0D254111C4EE569B [debian/upstream/signing-key.asc] I: trader source: vcs-field-uses-insecure-uri Git git://git.zap.org.au/data/git/trader.git -b with-debian P: trader source: source-contains-autogenerated-gperf-data [lib/iconv_open-hpux.h] P: trader source: source-contains-autogenerated-gperf-data [lib/iconv_open-irix.h] P: trader source: source-contains-autogenerated-gperf-data [lib/iconv_open-osf.h] P: trader source: source-contains-autogenerated-gperf-data [lib/iconv_open-solaris.h] P: trader source: source-contains-autogenerated-gperf-data [lib/iconv_open-zos.h] Cheers, -- tobi On Wed, Jan 31, 2024 at 10:59:26AM +1100, John Zaitseff wrote: > Hi, Bastian et al., > > > > > 7.19-1 was never uploaded to Debian, so please remove it from > > > > the changelog. > > > > > > Would this still be the case even though I _did_ release it on > > > The ZAP Group Australia's repository? If so, how would I > > > preserve the changes listed for v7.19 -- should I just add them > > > as part of the 7.20-1 changelog entry? > > > > Yes, you should do that. Alternatively, you can upload 7.19-1 > > before uploading 7.20-1. > > I have removed the changelog entry for 7.19-1; the entry for 7.20-1 > now reads: > > trader (7.20-1) unstable; urgency=low > > * New upstream release: changed documentation (history of the game), > updated Swedish, Norwegian Bokmål, French, German, Serbian, Esperanto, > Romanian, Polish and Ukrainian translations. > * Incorporates changes made to previous upstream release (not uploaded > to Debian): new Polish, Romanian and Ukrainian translations, renamed > AppStream metainfo and desktop files. > * Require at least Gettext 0.21 and Automake 1.16 for building. > * Updated to Debian Policy 4.6.2 (no changes). > > Could you (or someone) now sponsor the package? The original link > now points to the updated package: > > dget -x > https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/source/trader_7.20-1.dsc > > Yours truly, > > John Zaitseff > > -- > John Zaitseff ╭───╮ Email: j.zaits...@zap.org.au > The ZAP Group │ Z │ GnuPG: 0x0D254111C4EE569B > Australia Inc. ╰───╯ https://www.zap.org.au/~john/ >
