Control: tags 989365 - moreinfo Hello Tobias,
would you be able to help sponsor recastnavigation? I believe the final upload (#5) is the right now and according to: https://mentors.debian.net/package/recastnavigation/ lintian is green/happy. The package is listed as needing a sponsor but so far no takers. :( Time is running out as openmw-0.47.0 has been tagged and it depends on recastnavigation to build. Hopefully I've done my due-diligence here.| As a side note, I'm also prepping openmw as well. Could I bother you with uploading that as well or do I need to go through the same route? Cheers, Bret On Mon, Jun 14, 2021 at 11:27 PM bret curtis <psi...@gmail.com> wrote: > tags 989365 - moreinfo > > > On Sun, Jun 13, 2021 at 10:29 AM Tobias Frost <t...@debian.org> wrote: > >> On Sun, Jun 13, 2021 at 12:03:26AM +0200, bret curtis wrote: >> > > New packages (ITPs) can go to unstable; (they don't interfere with >> the freeze) >> > >> > https://mentors.debian.net/package/recastnavigation/ >> >> - the watch file seems not to work; (take a look at uscan(1) and >> https://wiki.debian.org/debian/watch#GitHub) >> You can also do some commit-based watch-file with uscan, uscan(1) says >> how to >> (I doing something like that in dhewm3 and rbdoom3bfg) > > > I updated this, but I couldn't test it directly because I was on a Ubuntu > laptop and the uscan failed on version=4 > Can you validate this please? > > - d/control: >> - cmake (>= 3) | cmake3 >> - there is no cmake3 package; drop that alternative. >> - the versioned dependency is not needed; even oldstable has cmake > 3 >> - shouln't the library package also be named librecastnavigation? >> (it should match the -dev package's name >> - you) >> >> > Took care of all of this as well. > > >> - d/copyright: >> - Can you add a debian/* section with your name to d/copyright? >> - I saw at least one file where the copyright years where 2010 and one >> file >> under PD not mentioned at all. There is also a font without source. >> (in the Demo) >> Please review every file and check your copyright file to make sure >> that it >> is complete. >> - (nitpick: Trailing whitespaces in d/copyright; plz remove… >> as you likely know wrap-and-sort(1) can do that for you. >> > > Nit picked. Everything is taken care of as well. We have a mix of: BSL-1, > Apache, MIT and GPL-3 :) > > >> (for the todo list -- not needed for this upload -- embedded code >> library: fastlz) >> This library is intended to be copied in the source; >> - that copy seems to be rather old. Maybe ask upstream to update >> to some more recent version? >> - Possibly fastlz should be pacakged… A file search seems to >> indicate that there would be other pacakges benefiting from this as >> well. >> - Check for more details: https://wiki.debian.org/EmbeddedCopies >> - It seems only be used in the demo; if you dont use the demo in any >> way, >> you could Files-Exclude the demo and be done. This would also fix the >> font >> issue. >> >> > fastlz is just for the demo and we do not currently ship the demo, so I'm > not worried about this. Upstream is aware of this and they rather embed > than use submodules, though I did push them to use cmake, so perhaps I can > convince them to use cmake's fetch content instead? They are > primarly focused on premake though. The Demo is not made here, so nothing > to Exclude. :) > > >> (can be done later too; no blocker for this upload:) >> I see a tests folder… Would it make sense to run them in autopkgtsts? >> > > This one I didn't do, but I can add this later. Is that okay? > > >> please review your package and remove the moreinfo tag when ready. >> > > Cool, thanks! :) > > Cheers, > Bret >
