On Thu, Dec 3, 2020 at 1:09 PM Romain Porte wrote: > Uploaded a new version +dfsg.1-1 on mentors with your explanation in > debian/copyright as suggested by Lintian.
Here is a review of the package: There do not appear to be any further issues that would block the upload. So I am willing to sponsor the package on the condition that once opentype-sanitizer enters Debian, you contribute a check for running it to check-all-the-things. https://github.com/collab-qa/check-all-the-things/ These issues would be nice to fix at some point: The URLs pointed to by the Vcs-* fields in debian/control do not appear to exist. Please update the package to the new upstream release 8.1.1. Please fix the remaining minor lintian complaints where possible. Please remove the debmake template comments from debian/rules if you aren't going to use them, although uncommenting the hardening one will fix one lintian complaint. The debian/copyright file indicates that the debian/ directory is licensed under the GNU GPLv3+. Usually it is recommended to use the same license as upstream, so that upstream can easily adopt anything that Debian includes in our package. This is especially important for manual pages and patches. I suggest using wrap-and-sort with these arguments to make it easier to read diffs of the debian/ directory. You seem to have already used most of these. wrap-and-sort --short-indent --wrap-always --sort-binary-packages --trailing-comma I note that the build process searches for freetype but the package does not build-depend on it, is that intentional? I note that the build uses a static library rather than a private shared library for libots, which bloats the package slightly. Please forward the GCC warnings from the build log (or a patch fixing them) to upstream. The following tools run by check-all-the-things produce output that you may want to review and or forward upstream: cppcheck anorack bashate blhc clang-check clang-tidy scan-build codespell cme check dpkg doc8 duck grep -nHrF http: shellcheck proselint spellintian wrap-and-sort yamllint -- bye, pabs https://wiki.debian.org/PaulWise
