On Fri, Mar 16, 2018 at 09:43:26AM -0500, Kurt Kremitzki wrote: > > > On 03/15/2018 04:37 PM, Tobias Frost wrote: > > On Wed, Mar 14, 2018 at 11:46:28AM +0100, Tobias Frost wrote: > > > What is still missing from my side is a complete d/copyright review, > > > but I need a break right now... Will continue later. > > > > Ok, went over the package for a copyright review. > > One part of the result resulted in a MR [1], but not all could > > be fixed with that; could be that we need to repack the source > > and/or ask upstream to fix that in their repo too. > > > > I fear that we have some problematic files: > > - There are some files from QT examples, but the license header seems to > > be "old" and unfortunatly not distributeable. > > Affected are some files in samples/qt/FuncDemo/src, e.g edge.cpp > > (Later versions of this file seems to be dual-licensed, so likely > > the remedy is to "update" to a newer version by upstream. > > But for now, I guess this samples can be removed from the tarball > > by repacking. > > These were the files I opened an upstream bug about [1] which they've > already provided a commit for [2], but the bug is tagged for 7.3.0 so I'll > make a patch to apply it here.
Unfortuantly a patch is not enough, as the problematic sources would still be in the tarball, which'd be not ok for copyright issues as we would still distribute them. (actually, we should remove them from the repository to be safe... git-filter can do that, I guess or nuke the repo and regenerate it from scratch. The latter would also fix another small issue with the repo: It'd be nice to import all old versions of Debian packaging from opencascade, using gbp import-dscs --debsnap) > > - src/NCollection/NCollection_UtfIterator.lxx > > Is also copyrighted by Unicode Inc. We'll need to have a dedicated > > section in d/copyright for it > > - src/OpenGl/glext.h needs also to be documented in d/copyright. > > Roger that. > > > - samples/ios/UIKitSample/UIKitSample/ViewController.* are > > "copyright ... all rights reserverd.". > > I guess we need to delete the iOS example from the tarball... > > - opencascade/samples/mfc/standard/06_Ocaf/src/DebugBrowser.hxx > > (example, there are others as well) scares me license wise. > > We will have to delete them (no big loss, as MFC examples are > > not really useful for us) or ask upstream to clarify. > > > > When we're repackaging anyway, we should also remove all those > > Windows-Only samples (and their VS project files) > > There are also some .bat files in the top-level directory that are not > needed. What is the proper procedure for getting rid of them all when > packaging with git? I guess we'll need to repack the source, so the removal would be done while creation of the orig.tar, before importing it into the git repo. (We need repacking because of the problematic sources; I would not bother with the extra files otherwise) One way would be to use the Files-Excluded: feature of d/copyright, picked up by uscan or an get-orig-source target for d/rules when you want to package from a git-commit. (I use the latter for some of my packages, look at dhewm3 or rbdoom3bfg -- IIRC the latter takes the list of files to be removed from Files-Excluded for get-orig-source) > > > > Otherwise were some years not accurate (fixed in [1]) and some copyright > > holders not "verbabitmly" coppied, but else there not much to fix > > left... > > > > > > [1] https://salsa.debian.org/kkremitzki-guest/opencascade/merge_requests/1 > > > > -- > > tobi > > > > > 1. https://tracker.dev.opencascade.org/view.php?id=29559 > 2. > http://git.dev.opencascade.org/gitweb/?p=occt.git;a=commitdiff;h=dd0fae1d0f3ad5faea55e78dee07d735730a2c61;hp=726b5d9e920db065d98ad1b79fc2ab1beb24ba49
