On Wed, Mar 14, 2018 at 11:46:28AM +0100, Tobias Frost wrote: > What is still missing from my side is a complete d/copyright review, > but I need a break right now... Will continue later.
Ok, went over the package for a copyright review. One part of the result resulted in a MR [1], but not all could be fixed with that; could be that we need to repack the source and/or ask upstream to fix that in their repo too. I fear that we have some problematic files: - There are some files from QT examples, but the license header seems to be "old" and unfortunatly not distributeable. Affected are some files in samples/qt/FuncDemo/src, e.g edge.cpp (Later versions of this file seems to be dual-licensed, so likely the remedy is to "update" to a newer version by upstream. But for now, I guess this samples can be removed from the tarball by repacking. - src/NCollection/NCollection_UtfIterator.lxx Is also copyrighted by Unicode Inc. We'll need to have a dedicated section in d/copyright for it - src/OpenGl/glext.h needs also to be documented in d/copyright. - samples/ios/UIKitSample/UIKitSample/ViewController.* are "copyright ... all rights reserverd.". I guess we need to delete the iOS example from the tarball... - opencascade/samples/mfc/standard/06_Ocaf/src/DebugBrowser.hxx (example, there are others as well) scares me license wise. We will have to delete them (no big loss, as MFC examples are not really useful for us) or ask upstream to clarify. When we're repackaging anyway, we should also remove all those Windows-Only samples (and their VS project files) Otherwise were some years not accurate (fixed in [1]) and some copyright holders not "verbabitmly" coppied, but else there not much to fix left... [1] https://salsa.debian.org/kkremitzki-guest/opencascade/merge_requests/1 -- tobi
