On Fri, Dec 22, 2017 at 10:18:32AM +0100, Geert Stappers wrote: > Control: owner -1 !
Great! Good to see someone with an interest in the package. > On Thu, Dec 21, 2017 at 08:26:45PM +0100, Adam Borowski wrote: > > I'm afraid the package fails to build, > > you need to add fasm to Build-Depends. > > Yes, we ((Albert & Geert) , who did meet 2017-12-21 ) can confirm > that fasm needs to be added to Build-Depends. > > About the "no packages needs to be build" we did see last night. > > That is because 'Architecture: i386' in debian/control > and doing `debuild -uc -us` on an amd64 computer. Mere "debuild" is no good for review purposes, as it doesn't use a clean chroot (might be still good for finding build-conflicts, though). > Having 'Architecture: amd64 i386' builds a package on amd64. Making the package work natively on amd64 (even if using i386 assembly) could be useful, yeah. Being i386-only is not a show stopper, though -- I believe d-i adds i386 multiarch by default these days. > Would it be okay to do another upload to mentors.debian.net for 5.3.0-1 ? > > (a next upload to debian would have an incremented debian version ( e.g. > 5.3.0-2 ) ) m.d.n allows replacing a package with the same version, yeah. And no one uploaded lina to Debian yet. > > Before we even start, it would be nice if you could address the rest of > > issues detected by lintian -- an automated system saves a lot of human > > time. > > Precious time of reviewers. (and yes, it does cost precious time from > the maintainer ( hey it gets higher quality )) I believe it saves the maintainer's time as well: preparing a mentors upload does take effort, so does writing an update mail, then handling the answer. We should advertise "lintian -i" more -- its explanations are pretty good, probably more helpful than a 1-2 line mention I tend to write. Meow! -- // If you believe in so-called "intellectual property", please immediately // cease using counterfeit alphabets. Instead, contact the nearest temple // of Amon, whose priests will provide you with scribal services for all // your writing needs, for Reasonable And Non-Discriminatory prices.
