Dear Marius, On Sat, Jan 21, 2017 at 11:34:38AM +0000, Marius Gavrilescu wrote: > Seems to be a caching issue on my end. Repo was updated, but Varnish was > still serving the old version. Seems to be working now, please tell me > if that is not the case.
That works! I'm sorry for not conducting a more through review before, but I've found the following remaining issues. Hopefully you can resolve them quickly and I can upload for you. 1. The package does not build against sid because the build-dep libfdk-aac-dev is not installable right now. Any ideas? 2. The change to Vcs-Git is not mentioned in the changelog. Optional suggestion: 3. Your git repository does not exactly match the source package you have provided. I've attached the diff. It's good practice to have your git HEAD exactly match what you want to be uploaded. But if this is difficult to fix, just ignore it and I will work from your source package. -- Sean Whitton
--- fdkaac-0.6.3.orig/MSVC/fdkaac.sln
+++ fdkaac-0.6.3/MSVC/fdkaac.sln
@@ -1,36 +1,36 @@
-
-Microsoft Visual Studio Solution File, Format Version 11.00
-# Visual Studio 2010
-Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "fdkaac",
"fdkaac.vcxproj", "{E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}"
-EndProject
-Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "fdk-aac",
"fdk-aac.vcxproj", "{D7D4B982-8B16-4A10-8B1C-9527BD789709}"
-EndProject
-Global
- GlobalSection(SolutionConfigurationPlatforms) = preSolution
- Debug|Win32 = Debug|Win32
- Debug|x64 = Debug|x64
- Release|Win32 = Release|Win32
- Release|x64 = Release|x64
- EndGlobalSection
- GlobalSection(ProjectConfigurationPlatforms) = postSolution
- {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Debug|Win32.ActiveCfg =
Debug|Win32
- {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Debug|Win32.Build.0 =
Debug|Win32
- {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Debug|x64.ActiveCfg =
Debug|x64
- {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Debug|x64.Build.0 =
Debug|x64
- {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Release|Win32.ActiveCfg
= Release|Win32
- {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Release|Win32.Build.0 =
Release|Win32
- {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Release|x64.ActiveCfg =
Release|x64
- {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Release|x64.Build.0 =
Release|x64
- {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Debug|Win32.ActiveCfg =
Debug|Win32
- {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Debug|Win32.Build.0 =
Debug|Win32
- {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Debug|x64.ActiveCfg =
Debug|x64
- {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Debug|x64.Build.0 =
Debug|x64
- {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Release|Win32.ActiveCfg
= Release|Win32
- {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Release|Win32.Build.0 =
Release|Win32
- {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Release|x64.ActiveCfg =
Release|x64
- {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Release|x64.Build.0 =
Release|x64
- EndGlobalSection
- GlobalSection(SolutionProperties) = preSolution
- HideSolutionNode = FALSE
- EndGlobalSection
-EndGlobal
+
+Microsoft Visual Studio Solution File, Format Version 11.00
+# Visual Studio 2010
+Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "fdkaac",
"fdkaac.vcxproj", "{E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}"
+EndProject
+Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "fdk-aac",
"fdk-aac.vcxproj", "{D7D4B982-8B16-4A10-8B1C-9527BD789709}"
+EndProject
+Global
+ GlobalSection(SolutionConfigurationPlatforms) = preSolution
+ Debug|Win32 = Debug|Win32
+ Debug|x64 = Debug|x64
+ Release|Win32 = Release|Win32
+ Release|x64 = Release|x64
+ EndGlobalSection
+ GlobalSection(ProjectConfigurationPlatforms) = postSolution
+ {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Debug|Win32.ActiveCfg =
Debug|Win32
+ {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Debug|Win32.Build.0 =
Debug|Win32
+ {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Debug|x64.ActiveCfg =
Debug|x64
+ {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Debug|x64.Build.0 =
Debug|x64
+ {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Release|Win32.ActiveCfg
= Release|Win32
+ {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Release|Win32.Build.0 =
Release|Win32
+ {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Release|x64.ActiveCfg =
Release|x64
+ {E62D32CF-E308-40BD-9FF0-8266C6CAA9AA}.Release|x64.Build.0 =
Release|x64
+ {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Debug|Win32.ActiveCfg =
Debug|Win32
+ {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Debug|Win32.Build.0 =
Debug|Win32
+ {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Debug|x64.ActiveCfg =
Debug|x64
+ {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Debug|x64.Build.0 =
Debug|x64
+ {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Release|Win32.ActiveCfg
= Release|Win32
+ {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Release|Win32.Build.0 =
Release|Win32
+ {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Release|x64.ActiveCfg =
Release|x64
+ {D7D4B982-8B16-4A10-8B1C-9527BD789709}.Release|x64.Build.0 =
Release|x64
+ EndGlobalSection
+ GlobalSection(SolutionProperties) = preSolution
+ HideSolutionNode = FALSE
+ EndGlobalSection
+EndGlobal
signature.asc
Description: PGP signature
