> > > > During last week's DebConf I participated in a Go sprint, and one of > > > > the tasks > > > > assigned was to add this file to several packages [1] and then adjust > > > > the CI > > > > configuration. The first part I did was add this file; the second step > > > > I was > > > > going to do was adjust the CI configuration. > [...] > > I support what Marcos is doing, having a standard name is best. I am unsure > > of what you are complaining. > > It isn't clear in the commit messages that the CI config was updated as > well; to me, it looked like the file was just being added. Only after > checking settings for at least one project I could see CI was changed to > point to debian/salsa-ci.yml. > > The main issue is that debian/gitlab-ci.yml was just left behind; this > should be removed from any repos where Marcos has added a salsa-ci.yml > file.
It depends on the situation. See various scenarios and how to handle them in these examples: https://salsa.debian.org/go-team/packages/powerline-go/-/merge_requests/1 https://salsa.debian.org/go-team/packages/golang-github-yuin-gopher-lua/-/merge_requests/4 https://salsa.debian.org/go-team/packages/golang-gopkg-yaml.v3/-/merge_requests/5 https://salsa.debian.org/go-team/packages/golang-github-alicebob-miniredis/-/merge_requests/4 https://salsa.debian.org/go-team/packages/privatebin-cli/-/merge_requests/1 It is OK to leave gitlab-ci.yml for backwards compatibility but it should point to salsa-ci.yml - there sholdn't be to different CI definitions. Also one should never enable CI that is broken out-of-the-box, but ensure it actually passes. This is the most important rule. If that rule had been followed, it would have been obvious in all cases where the CI setting was wrong, unnecessary, or had no effect etc. If one mechanically just throws the file everywhere without following up, the end result is random and most likely just a mess waiting to be cleaned up by someone who actually checks the state of things before and after, and what is lacking to get an actual running Salsa CI in the repo.
