Hi Ahmad, On Tue, 2025-01-14 at 19:47 +0000, Ahmad Khalifa wrote: > > ===== d/control ===== [...] > > - This is not a library that others can depend on. The "heckel-ntfy-v2- > > dev" (which isn't named correctly BTW) stanza should be removed > > entirely, as well as any related files like its install file. > > Isn't the source usually packaged for others to depend on? Nothing needs > it right now, but is it considered unnecessary noise?
If upstream doesn't intend for it to be imported by others, then we shouldn't package the source as a library. It's only a program, and its code isn't intended for consumption by other software. > Just curious, what's the right namespace for `module heckel.io/ntfy/v2`? golang-heckel-ntfy-dev > > > > ===== d/rules ===== > > > > - Instead of setting DH_GOLANG_INSTALL_ALL = 1 and then specifying > > DH_GOLANG_EXCLUDES, use DH_GOLANG_INSTALL_EXTRA to specify only the > > additional things required for the build to proceed. > > I'll look at this again, but I need the excludes so I can avoid patching > the excluded dirs. Ack. > > - Move the .service files out of d/systemd and directly into debian/ so > > dh_installsystemd picks them up. Replace > > "execute_after_dh_installsystemd" with the following to prevent starting > > or enabling them. > > > > override_dh_installsystemd > > dh_installsystemd --no-start --no-enable > > This didn't work - I tried many combinations, but it always ended up > starting the service. I'll try it again, but the only thing that worked > was hiding the service files from dh completely then installing at a > later stage OR installing directly into the debian/ntfy at a late stage, > but then no postinst comes out (for upgrade reboots) Once you push updated changes to the repo, I can inspect the postinst script generated by debhelper and see what's going on. > > See the dh_installsystemd(1) manual page, accessible by web at [7], for > > more information. > > > > - You do not need to manually invoke dh_installsysusers. It is run > > automatically as part of the debhelper sequence. > > And neither did this. Drilling into dh, I found this line in the root > sequence: > > $include_if_compat_X_or_newer->(14, 'dh_installsysusers') > > The package is currently compat=13. Ah. In that case, you can pass "--with=installsysusers" to dh. > > > - The "notdebian" tag is misleading, and isn't necessary to patch out > > files from the build. Use "//go:build ignore" in your patches instead. > > Ohh, I didn't know "ignore" was a static recognised keyword. I thought > you still had to pass it to -tags. Well this probably solves the above > issue then. It's not :) - it's merely a convention that it's named "ignore". Nothing will pass the "ignore" tag, so it won't build, and you won't need to add anything extra to the dh_auto_build invocation in d/rules. -- Maytham Alsudany Debian Maintainer
signature.asc
Description: This is a digitally signed message part
