Hi Sebastian and list, I just wanted to ping back on this in case there is anything more needed on my side.
I'm hoping review comments to date are all addressed: is there anything further I need to do to get the package submitted? Apologies if I'm being impatient: I don't mean to be, I'm just worried as someone new to Debian packaging that I've missed something I need to do! Best regards, Tom On Thu, Sep 21, 2023 at 15:58:08 +0100, Tom Parkin wrote: > Hi again Sebastian, > > Just to follow up on my earlier email: > > > 1. I have pushed my packaging tree to Salsa[1], including both the > 'upstream' and 'debian/sid' branches. > > > 2. I've reworked the package description so it's more in line with > the ITP bug wording. I think this is more specific to what is > actually packaged. > > I've also removed go-l2tp.lintian-overrides file since the override > is no longer required. > > > 3. I confirm that 'override_dh_auto_install' was autogenerated by the > dh-make-golang tool (per Cyril's earlier remarks). > > FWIW, dh-make-golang's behaviour here seems to date back to 2018 > or so in the dh-make-golang git repo -- there's an issue there > which describes the rationale[2]. > > I had a quick look at some other "program" type packages (e.g. > cgo, elvish) which have the same override, but it doesn't seem to > be universally applied so far as I can make out, so I'm not sure > what the best thing to do here is. > > Should I keep the override do you think? > > > Finally, I notice that lintian reports a couple of issues related to > binary hardening: > > * W: go-l2tp: hardening-no-pie [usr/bin/kl2tpd] > * I: go-l2tp: hardening-no-bindnow [usr/bin/kl2tpd] > > I'm not sure how to fix these in the context of the go toolchain. > Should I add lintian overrides for these, or somehow address them in > the build process? > > Thanks again and best regards, > Tom > > [1]. https://salsa.debian.org/go-team/packages/golang-github-katalix-go-l2tp > [2]. https://github.com/Debian/dh-make-golang/issues/57 > > On Thu, Sep 21, 2023 at 12:20:50 +0100, Sebastian Crane wrote: > > Dear Tom, > > > > Welcome to the Debian Go Packaging Team! I've reviewed your packaging > > on your GitHub repository and have some suggestions and comments. > > > > - You'll need to push an 'upstream' branch as well as the 'debian/sid' > > branch to Salsa when you get access. > > > > - The description shouldn't be the whole README; you can just have 'Go > > library for building L2TP applications on Linux systems' on the first > > line and the list of features as the extended description. If you > > think it's important that users have access to the documentation, you > > can put something in /usr/share/doc (it looks like you've already got > > manpages there already). It is generally unusual to have extra > > documentation for Go libraries in Debian, since they aren't really > > intended for use outside of making other Debian software work. > > > > - If you abridge the description, you can also delete > > go-l2tp.lintian-overrides. > > > > - Why do you have an 'override_dh_auto_install' rule in the Makefile? I > > don't know if something has changed recently in dh-make-golang, but it > > wasn't there last time I used it. > > > > All in all, I think it looks pretty close to upload :) > > > > Best wishes, > > > > Sebastian > > > > > > On Thu, Sep 21, 2023 at 11:58:12AM +0100, Tom Parkin wrote: > > > Hi all, > > > > > > I am Tom Parkin, and I'm working on a Debian package for the go-l2tp > > > project[1]. > > > > > > I have followed the dh-make-golang tutorial and produced working > > > packaging which builds using gbp buildpackage[2]. > > > > > > I have a Salsa account, and have created the > > > golang-github-katalix-go-l2tp project -- however I don't have > > > permissions to push code to the project yet. Hopefully this won't > > > cause a problem! > > > > > > I'd like to request a review of my packaging and request sponsorship > > > for upload. > > > > > > Many thanks, > > > Tom > > > > > > [1]. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051983 > > > [2]. https://github.com/katalix/go-l2tp-debian
signature.asc
Description: PGP signature
