Dear Tom, Welcome to the Debian Go Packaging Team! I've reviewed your packaging on your GitHub repository and have some suggestions and comments.
- You'll need to push an 'upstream' branch as well as the 'debian/sid' branch to Salsa when you get access. - The description shouldn't be the whole README; you can just have 'Go library for building L2TP applications on Linux systems' on the first line and the list of features as the extended description. If you think it's important that users have access to the documentation, you can put something in /usr/share/doc (it looks like you've already got manpages there already). It is generally unusual to have extra documentation for Go libraries in Debian, since they aren't really intended for use outside of making other Debian software work. - If you abridge the description, you can also delete go-l2tp.lintian-overrides. - Why do you have an 'override_dh_auto_install' rule in the Makefile? I don't know if something has changed recently in dh-make-golang, but it wasn't there last time I used it. All in all, I think it looks pretty close to upload :) Best wishes, Sebastian On Thu, Sep 21, 2023 at 11:58:12AM +0100, Tom Parkin wrote: > Hi all, > > I am Tom Parkin, and I'm working on a Debian package for the go-l2tp > project[1]. > > I have followed the dh-make-golang tutorial and produced working > packaging which builds using gbp buildpackage[2]. > > I have a Salsa account, and have created the > golang-github-katalix-go-l2tp project -- however I don't have > permissions to push code to the project yet. Hopefully this won't > cause a problem! > > I'd like to request a review of my packaging and request sponsorship > for upload. > > Many thanks, > Tom > > [1]. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051983 > [2]. https://github.com/katalix/go-l2tp-debian > -- > Tom Parkin > Katalix Systems Ltd > https://katalix.com > Catalysts for your Embedded Linux software development
