Hi! Here we go again...
On 03/09/18 09:10, Sebastiaan Couwenberg wrote: > Hi Alec, > > On 9/2/18 9:54 PM, Alec Leamas wrote: > Yes, you have a "Files: *" section, but it has the same license and the > Files section that follows it. Those sections can be merged But, they have different copyright: stanzas?! > Note the content of the AUTHORS file, it mentions that most of the code > is under the LGPL-3, but some other files are public-domain, this is not > reflected in the copyright file. Indeed. Fixed. > But the space should be used consistently for the benefit of human readers. OK :) Fixed. > * debian/docs > > It includes the README.source, and will be included in the first binary > package listed in debian/control (because it doesn't include the package > in its filename), but it doesn't belong there. Removed it. > * debian/README.source > > sed -i 's/walk-around/workarounds/g' debian/README.source > > The get-orig-source target should not be invoked with fakeroot, as there > is no need to root permissions. `make -f debian/rules get-orig-source` > is more appropriate. Or just `./debian/rules get-orig-source` since it > has the make hashbang. Fixed. > * debian/gbp.conf > > There is not git-buildpackage configuration included in the package, and > hence pristine-tar is not used by default. You should add this file, see: Done > Because there was gbp.conf when the upstream tarball was first imported, > and the --pristine-tar option was not used, you need to create the > pristine-tar branch yourself: Done Cheers! --alec
