Hi Abou, Quoting Abou Al Montacir (2025-02-01 13:13:32) > According > to https://udd.debian.org/patches.cgi?src=lazarus&version=3.8%2Bdfsg1-4 my > package have a patch with invalid metadata. There seem to be that the tool > considers the following as an error: > Forwarded: Yes > Bug-Upstream: https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/41378 > > This is despite that https://dep-team.pages.debian.net/deps/dep3/, which is > given as a hint by the tool, states clearly that: > > * Forwarded (optional)Any value other than "no" or "not-needed" means that > > the > > patch has been forwarded upstream. Ideally the value is an URL proving that > > it has been forwarded and where one can find more information about its > > inclusion status.If the field is missing, its implicit value is "yes" if the > > "Bug" field is present, otherwise it's "no". The field is really required > > only if the patch is vendor specific, in that case its value should be "not- > > needed" to indicate that the patch must not be forwarded upstream (whereas > > "no" simply means that it has not yet been done). > So the natural value "yes" is considered as an error, just because the (not > so) > ideal value is not used. > > Without arguing too much why using "Forwarded" followed by "Bug-upstream" is > much better than the ideal proposed value, I consider that the check tool > implementation is wrong. However I would like to hear from others what do they > think before asking to relax the check.
I agree with your interpretation, that "Forwarded: Yes" is legal, and therefore a parser that flags that as illegal is a broken parser. That said, I find it superfluous to ever state "Forwarded: Yes", because it is never sensible to state that without also stating to *where* it is forwarded, and stating that implies "Forwarded: Yes" - as you also quote above. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ * Sponsorship: https://ko-fi.com/drjones [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
