On Tue, Jun 20, 2023 at 08:47:54AM +0200, Ricardo Ribalda Delgado wrote:
> On Tue, Jun 20, 2023 at 7:46 AM Andrea Righi <andrea.ri...@canonical.com>
> wrote:
> >
> > On Mon, Jun 19, 2023 at 09:54:41PM +0200, Ricardo Ribalda Delgado wrote:
> > > Hi
> > >
> > > I have updated my repo to uprev v1.10 and support argcomple3.
> > >
> > > https://salsa.debian.org/ribalda/virtme-ng/-/tree/debian
> > >
> > > Hector, Andrea, can you take a look at it?
> > >
> > > Hector the fun bits are at
> > > https://salsa.debian.org/ribalda/virtme-ng/-/merge_requests/1/diffs?commit_id=943dd90136e5e30fc39d0061347fea3bcbe44c4c
> >
> > Reviewed and added some comments, thanks!
> >
> > >
> > > Andrea: the build seems to be having issues with 32 bits:
> > > https://salsa.debian.org/ribalda/virtme-ng/-/jobs/4338837
> >
> > Ah yes, I hit that yesterday as well:
> > https://launchpadlibrarian.net/673040751/buildlog_ubuntu-mantic-armhf.virtme-ng_1.12-1ubuntu1_BUILDING.txt.gz
>
> Can you check if
> https://salsa.debian.org/ribalda/virtme-ng/-/blob/debian/debian/patches/32bit.patch
> does the trick for you?
usize seems to do the trick for me, I think it's more portable than
c_ulong (that comes from std::os::raw:c_ulong).
I'll push a fix soon, I just want to make sure it builds everywhere
(testing right now). :)
-Andrea
>
> warning! not a rust hacker myself :P
>
> >
> > Part of these errors are fixed by:
> > `879b4d4 ("virtme-ng-init: support 32-bit architectures")`
> >
> > But there are still some 32-bit related errors, I'll push an additional
> > fix later today.
> >
> > -Andrea
