On Mon, Jun 19, 2023 at 02:15:51PM +0200, Héctor Orón Martínez wrote:
> Hello,
>
> On Mon, 19 Jun 2023 at 13:56, Andrea Righi <andrea.ri...@canonical.com> wrote:
> >
> > On Mon, Jun 19, 2023 at 01:20:04PM +0200, Héctor Orón Martínez wrote:
> > > Hello Andrea,
> > >
> > > On Wed, 31 May 2023 at 20:47, Andrea Righi <andrea.ri...@canonical.com>
> > > wrote:
> > >
> > > > On Mon, May 15, 2023 at 10:45:15PM +0200, Ricardo Ribalda Delgado wrote:
> > >
> > > > > I think I have the first version of virtme-ng.
> > > > >
> > > > > @Héctor Orón Martínez can you help reviewing and pushing
> > > > > https://salsa.debian.org/ribalda/virtme-ng ?
> > > > >
> > > > > Maybe you could also create salsa.debian.org/debian/virtme-ng
> > > >
> > > > Is there any update on this? Anything I can do to help?
> > >
> > > I tried to build the package posted in the salsa repo, but failed for
> > > me, then I was unable to get back to this. Have you been able to
> > > review such a source tree?
> >
> > I'm able to build the package from Ricardo's repo. It's still at v1.6
> > and upstream is already v1.10, but in general it looks good to me.
> >
> > What error did you get?
>
> I tried in a different machine now:
>
> register-python-argcomplete virtme-ng > virtme-ng-prompt
> /bin/sh: line 1: register-python-argcomplete: command not found
>
> This should be register-python-argcomplete3, solving that issue I was
> able to build it.
Oh I see, in Ubuntu python3-argcomplete provides
register-python-argcomplete, while in Debian it's
register-python-argcomplete3.
Not sure why it's different, maybe we should just do something like the
following to support both (if you like it I'll apply it upstream).
Thanks for checking!
-Andrea
debian/rules | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/debian/rules b/debian/rules
index db18ccd..0888cf2 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,13 @@
#!/usr/bin/make -f
+ARGCOMPLETE := $(shell command -v register-python-argcomplete3 2>/dev/null ||
command -v register-python-argcomplete 2>/dev/null)
+
+ifeq ($(strip $(ARGCOMPLETE)),)
+ $(error Neither register-python-argcomplete nor
register-python-argcomplete3 found in PATH)
+endif
+
virtme-ng-prompt:
- register-python-argcomplete virtme-ng vng > $@
+ $(ARGCOMPLETE) virtme-ng vng > $@
%:
dh $@ --with python3 --buildsystem=pybuild
