On Mon, Apr 08, 2019 at 03:50:19PM +0300, Tzafrir Cohen wrote:
> Hi,
>
> The README states a directory structure with a top-level collection
> directory, but the repository currently does not include one.
The github.com:dupr/DefaultCollection.git repo is indeed a specification
compliant if you mangle the first layer of directory structure.
```
--- a/README
+++ b/README
@@ -17,7 +17,7 @@ name. Plus, no one prevents you from submitting a debian
directory.
For example:
-A-Certain-Collection/
+A-Certain-Collection/ # For example, this git repository.
library-foo/
library-foo.durpkg
library-foo-ubuntu.durpkg
```
> Looking at:
>
>
> https://github.com/dupr/DefaultCollection/blob/master/rover/rover.durpkg
>
> I see that the name of the directory repeats quite a number of times.
> The clean function needs to state 'rm -rf' explicitly, which I hope
> won't lead to typos.
The repetition of "pushd" and "popd" is something that could be improved
later. So the same as the 'rm -rf' hook. The two problems have been
tracked here:
https://github.com/dupr/duprkit/issues/3
https://github.com/dupr/duprkit/issues/4
Please don't expect too much from a prototype rushed within several
hours. That's used for presenting the idea instead of presenting
a graceful implementation.
> The changelog is buried deep inside the package an needs to be updated
> whenever a version number is bumped.
AUR's PKGBUILD doesn't record changes. If you feel like that the dch
has been deeply buried, the usage of traditional debian/ directory
layout is still supported:
https://github.com/dupr/DefaultCollection/tree/master/rover-traditional
https://github.com/dupr/DefaultCollection/blob/master/rover-traditional/debian/changelog
One could easity convert the packaging between single-file format and
debian/ directory with a single-command-cost (virtually zero-cost).
