On Tue, 2022-07-19 at 13:42 +0100, Luca Boccassi wrote: > On Tue, 2022-07-19 at 13:03 +0100, Simon McVittie wrote: > > On Sun, 17 Jul 2022 at 14:21:30 +0100, Luca Boccassi wrote: > > > So the reasoning behind adding the override to debootstrap in -- > > > variant=buildd mode is twofold. > > > > > > From a very practical perspective, it means it's supereasy to allow all > > > those builds and tools you mentioned to run in unmerged-usr, there's no > > > extra config or code changes required anywhere else, it just works. > > > > Shouldn't `debootstrap --no-merged-usr` also have this behaviour for > > other variants? If a "larger" component like autopkgtest or piuparts > > explicitly asks for non-merged /usr in some other variant (in practice > > it would usually be minbase or default for those tools), it seems like > > debootstrap should do as it says, even if that means going into the > > unsupported mode. > > > > --variant=buildd currently implies --no-merged-usr, so this would still > > provide the behaviour you want for buildds. > > > > For the older suites where absence of an explicit option is equivalent > > to --no-merged-usr, this flag-file wouldn't be created anyway, because > > it's an older suite that doesn't need it? > > > > (I've commented as such on debootstrap!71.) > > Initial feedback on IRC was to keep these separate given the result is > unsupported, but I can certainly change that as you suggested, will > update the MR shortly. > > > > From a strategic point of view, catching all those class of bugs you > > > mentioned is not trivial > > > > It'll be even less trivial if we remove the ability for autopkgtest and > > piuparts to (create chroots that will) test this code path, which is > > why I asked for an opt-out mechanism in the first place... > > Yes that is understood and agreed, the intention was always to let the > CI tools do that, there's some back and forth on how exactly to make > that happen but nothing unsurmountable.
Updated as requested, now --no-merged-usr adds the file flag for all variants on bookworm+: https://salsa.debian.org/installer-team/debootstrap/-/merge_requests/71 -- Kind regards, Luca Boccassi
signature.asc
Description: This is a digitally signed message part
