Cyril Brulebois:
Hej Niels,

Niels Thykier <ni...@thykier.net> (2025-01-04):
The transition has moved to the endgame and this bug is now RC. This bug is
filed on the assumption that the remark in d/rules about a part of the code
needing root is true. The provided patch (MR) explicitly has
debian-installer opt-in to the previous status quo of `debian/rules binary`
being run under (fake)root, so it should have 0 risk of regressions from a
package build perspective.

We have a few weird things with other wrappers already, I guess it'd be
best to see what happens when dpkg flips the switch (which I think
remains to happen, but I only glanced at the thread on -release@), and
act accordingly.


The switch has already been flipped (dpkg/1.22.13).

Note it can in theory also cause wrong ownership in produced artifacts. Anything build by `dh_builddeb` will be sanitized correctly, but as I recall `debian-installer` does an extra non-deb artifact, which might want some review for builds *without* this patch (it might leak the building users name/uid into tarballs, etc.).

With the patch applied, everything should go back to how it was previously, since `fakeroot` will reappear where it used to be.

[...]
So, we are back to: Would it be helpful if I NMUed the debian-installer
package? If not, then I will leave it in your capable hands.

Please leave it to me, but thanks for offering!

(Depending on the versioning the package might get rejected anyway, or
at least lead to some inconsistent state, see the version check in dak's
scripts/debian/byhand-di — Here be dragons.)


Cheers,

Super, will do. I was afraid this (like shim) would be a "here be dragons", so I am very happy to leave it to you.

Best regards,
Niels

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to