Bo YU <tsu.y...@gmail.com> 于2024年11月13日周三 00:06写道:
>
> Hi,
>
> On Tue, Nov 12, 2024 at 06:40:42PM +0800, YunQiang Su wrote:
> >On Tue, 12 Nov 2024 17:22:12 +0800 Bo YU <tsu.y...@gmail.com> wrote:
> >> > xxkb (1.11.1-3) unstable; urgency=medium
> >> > .
> >> >   * QA upload.
> >> >   * Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue.
> >> >     (Closes: #1075694)
> >> >   * Set std-ver to 4.7.0.
> >> >   * Add Rules-Requires-Root on d/control.
> >> >   * Add doc-base for xxkb.
> >> >   * debian/rules: clean up Makefile explicitly.
> >> >   * debian/rules: update CDEBUGFLAGS to fix hardening issue.
> >>
> >> Oops, I forget the debdiff about this, sorry for that.
> >>
> >
> >    $(MAKE) CDEBUGFLAGS="$(CFLAGS) $(LDFLAGS) $(CDEBUGFLAGS)"
> >will override the options in Imakefile: -Wall is missing.
> >I don't think that it is a good idea.
>
> Ah, I did not notice that. Thanks for pointing out this and I think the
> patch you proposed is more robust.
>
> Updated it again, thanks.
>

I guess that you missed the changes of d/rules?
-       $(MAKE) CDEBUGFLAGS="$(CFLAGS) $(LDFLAGS) $(CDEBUGFLAGS)"
+       $(MAKE) DEB_CDEBUGFLAGS="$(CFLAGS) $(LDFLAGS)"

>
> --
> Regards,
> --
>    Bo YU
>


-- 
YunQiang Su

Reply via email to