On Tue, 5 Nov 2024 11:25:58 +0800 Bo YU <tsu.y...@gmail.com> wrote:
> Hi,
>
> On Tue, Nov 05, 2024 at 10:56:09AM +0800, Bo YU wrote:
> >Hi,
> ...
> >
> >I have uploaded it to mentor also. Please review it. Could you upload it
> >if there are no other issues? TIA.
> >
> >```
> >
> >The source builds the following binary packages:
> >
> > xxkb - Keyboard state indicator and switcher for xkb
> >
> >To access further information about this package, please visit the following
> >URL:
> >
> > https://mentors.debian.net/package/xxkb/
> >
> >Alternatively, you can download the package with 'dget' using this command:
> >
> > dget -x
> > https://mentors.debian.net/debian/pool/main/x/xxkb/xxkb_1.11.1-3.dsc
> >
> >Changes since the last upload:
> >
> > xxkb (1.11.1-3) unstable; urgency=medium
> > .
> > * QA upload.
> > * Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue.
> > (Closes: #1075694)
> > * Set std-ver to 4.7.0.
> > * Add Rules-Requires-Root on d/control.
> > * Add doc-base for xxkb.
> > * debian/rules: pass CFLAGS to dh_auto_build.
>
> Sorry for the useless entry of the chanelog, I have this with v2.
>
It has a couple of problems:
1. it fails to run multiple times of `dpkg-buildpackage -B` due to
that the generated Makefile is not cleaned.
You may need to clean it.
2. The changelog entry `* debian/rules: pass CFLAGS to dh_auto_build.`
is misleading.
3. Hardcode hardening options is not a good idea.
You can do something like
override_dh_auto_build:
HARDEN_CFLAGS="`dpkg-buildflags --get CFLAGS` `dpkg-buildflags
--get LDFLAGS`" \
dh_auto_build
And in Imakefile
CDEBUGFLAGS = -O2 -Wall -g $(HARDEN_CFLAGS)
4. It seems that it can support librsvg. Why is it not enabled?
>
