Hi Bo, thanks for proposing a patch... (more: see below).
On Mi 06 Dez 2023 10:31:52 CET, Bo YU wrote:
Source: onboard Version: 1.4.1-5 Followup-For: Bug #1057442 Tags: patch Dear Maintainer, I think it is okay to remove `-Wdeclaration-after-statement` option which to support Arch linux build from code comment. please notice here also, even if the issue is fixed, the package will be build failed again when running tests: ``` ... dh_auto_test -O--buildsystem=pybuildI: pybuild base:310: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build; python3.12 -m unittest discover -v /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build/Onboard/utils.py:151: SyntaxWarning: invalid escape sequence '\d'"""/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build/Onboard/utils.py:220: SyntaxWarning: invalid escape sequence '\s'pattern = re.compile('>\n\s+([^<>\s].*?)\n\s+</', re.DOTALL)/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build/Onboard/utils.py:221: SyntaxWarning: invalid escape sequence '\g'pretty_xml = pattern.sub('>\g<1></', ugly_xml)/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build/Onboard/utils.py:356: SyntaxWarning: invalid escape sequence '\:'"""/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build/Onboard/utils.py:1542: SyntaxWarning: invalid escape sequence '\w'"""(?: Onboard (unittest.loader._FailedTest.Onboard) ... ERROR ====================================================================== ERROR: Onboard (unittest.loader._FailedTest.Onboard) ---------------------------------------------------------------------- ImportError: Failed to import test module: Onboard Traceback (most recent call last): File "/usr/lib/python3.12/unittest/loader.py", line 427, in _find_test_path package = self._get_module_from_name(name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^File "/usr/lib/python3.12/unittest/loader.py", line 337, in _get_module_from_name__import__(name)File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build/Onboard/__init__.py", line 23, in <module>from Onboard.utils import TranslationFile "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build/Onboard/utils.py", line 933, in <module>import cairoFile "/usr/lib/python3/dist-packages/cairo/__init__.py", line 1, in <module>from ._cairo import * # noqa: F401,F403 ^^^^^^^^^^^^^^^^^^^^^ ModuleNotFoundError: No module named 'cairo._cairo' ---------------------------------------------------------------------- Ran 1 test in 0.000s FAILED (errors=1)E: pybuild pybuild:395: test: plugin distutils failed with: exit code=1: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build; python3.12 -m unittest discover -v I: pybuild base:310: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_onboard/build; python3.11 -m unittest discover -v---------------------------------------------------------------------- Ran 0 tests in 0.000s OK ``` I do think this is one issue from python-cairo even depend on the latest version[0]. But if look back its buildd log[1] these tests are also not executed correctly. I am not sure how to deal with this and if skip test explicit it willl be okay.[0]: https://tracker.debian.org/news/1483436/accepted-pycairo-1251-1-source-into-unstable/ [1]: https://buildd.debian.org/status/fetch.php?pkg=onboard&arch=amd64&ver=1.4.1-5%2Bb8&stamp=1701806362&raw=0
The underlying cause of the cairo import issue is that /usr/lib/python3/dist-packages/cairo/_cairo.cpython-312-x86_64-linux-gnu.so is not yet contained in python3-cairo. Only the _cairo.cpython-311-x86_64-linux-gnu.so build is in that package. I just pinged the #debian-python IRC channel to check how this could best be fixed (likely via a binNMU).
I might assume that other packages could be affected by a missing binNMU... Waiting for IRC feedback... Mike -- mike gabriel aka sunweaver (Debian Developer) mobile: +49 (1520) 1976 148 landline: +49 (4351) 486 14 27 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: sunwea...@debian.org, http://sunweavers.net
pgp_L2t4A00aM.pgp
Description: Digitale PGP-Signatur
