Axel Beckert wrote:
> Control: tag -1 + unreproducible moreinfo
>
> Hi Jamie,
>
> Jamie Heilman wrote:
> > fping[4709]: segfault at 1 ip 00007f2c04511e2c sp 00007fffe869a550 error 4
> > in libc-2.19.so[7f2c044c7000+19f000]
> >
> > [New LWP 4709]
> > Core was generated by `fping -a'.
> > Program terminated with signal SIGSEGV, Segmentation fault.
>
> I'm sorry, but I can't reproduce that issue, neither on Sid amd64 or
> on Sid amd64.
>
> Please use reportbug (or equivalent) to report bugs because without
> your bug report doesn't contain any meta information about your system
> (i.e. what release you're using, at which version all of fping's
> dependencies were at the time of writing, etc.).
Not relevant information.
The "%s from %s for ICMP Echo sent to %s" format being passed to
vfprintf only exists in a single spot in the software. That makes it
obvious where this is occuring. A diff between the 3.10 and 3.12
made for interesting reading, and I spotted the problem. Here's a
patch:
--- fping-3.12.orig/src/fping.c
+++ fping-3.12/src/fping.c
@@ -1741,7 +1741,7 @@ int handle_random_icmp(FPING_ICMPHDR *p,
addr_ascii, h->host );
}
else {
- print_warning("%s from %s for ICMP Echo sent to %s",
icmp_code, addr_ascii, h->host);
+ print_warning("%s from %s for ICMP Echo sent to %s",
icmp_unreach_str[icmp_code], addr_ascii, h->host);
}
if( inet_addr( h->host ) == INADDR_NONE )
> BTW, what should "fping -a", i.e. without any target do? The man page
> doesn't mention any default target.
>
> For me it just seems to hang infinitely without any output. (Haven't
> waited for long, though.) I'd rather expect that either exits
> immediately and successfully or exits unsuccessfully with an error
> message stating that at least one target is required.
What any program that expects input on stdin should do, block and wait
for the end of file.
--
Jamie Heilman http://audible.transient.net/~jamie/
