Hi, Andreas Tille wrote: > I was able to commit[1] a fix for this bug. I'd like to wait for a > confirmation of a Perl Group member whether this is OK for a team upload > or whether this is to less Perl-ish and rather Debian-Med-ish.
Maybe that's partially the case... > [1] > https://anonscm.debian.org/cgit/pkg-perl/packages/libgenome-perl.git/commit/?id=205ec3992bde59d9f59870218e68cf9964d60a1a > There's one thing in this commit which I consider quite ugly and unnecessary: A man page being under /usr/lib/debian-med/share/man/man1/gmt.1.gz and then only symlinked to /usr/share/man/man1/genome-model-tools.1.gz. IMHO that's for two reasons: /usr/lib/debian-med/bin/gmt doesn't need a man page from a policy point of view, only /usr/bin/genome-model-tools does. And then there is a never to be found man page under /usr/lib. (A man page under /usr/lib? Come on! That's an FHS violation. Or rather was until Debian weakend it for the systemd guys.) So rather than moving the man page from /usr/share/man/man1/gmt.1.gz to /usr/lib/debian-med/share/man/man1/gmt.1.gz and then symlinking that to /usr/share/man/man1/genome-model-tools.1.gz, I'd just rename /usr/share/man/man1/gmt.1.gz to /usr/share/man/man1/genome-model-tools.1.gz -- Everything else is IMHO unnecessary complexity with horribly non-standard paths. And you would also spare the explicit gzip call and one of the lines in debian/dirs. Additionally there seems trailing whitespace in debian/links, but the affected line will be gone anyways if the above is fixed as suggested. Further there is a change in debian/control which is not mentioned in the changelog entry nor seems to be related to the rest of the commit: A line "Recommends: med-config (>= 2.1)" has been added. Please add at least an according changelog entry for that or remove it again (if it was committed accidentially). Regards, Axel -- ,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
