On Mon, Sep 8, 2014 at 7:51 PM, Simon Ruderich <si...@ruderich.org> wrote: > On Wed, Sep 03, 2014 at 06:17:52PM -0400, Felipe Sateler wrote: >> The problem is that such a blacklist could include other invalid shell >> characters: + comes to mind, but I don't know the entire set of >> character which are allowed as shell variables, as opposed to the >> valid make allowed chars. > > Hello Felipe, > > True, but I think those characters won't occur very often and I > wanted to provide a general fix which won't brake in the future > when new options are added.
Yes, but there are letters that are invalid as shell characters[1]: > Package names must consist only of lower case letters (a-z), digits (0-9), > plus (+) and minus (-) signs, and periods (.). [1] https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Source > >> Maybe a more appropriate way would be to, instead of filtering out the >> -, filter by matching FLAGS (after the DEB_ prefix)? > > Not all options contain FLAGS in their name, e.g. > DEB_BUILD_MAINT_OPTIONS. Could you propose a patch filtering out the characters plus (+), minus (-) signs, and periods (.)? My make-fu is not very good... -- Saludos, Felipe Sateler -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
