Quoting Felipe Sateler (2014-09-03 20:47:58) > Control: reopen -1 > Control: severity -1 serious > > On Thu, 21 Aug 2014 22:04:00 +0000 Jonas Smedegaard <d...@jones.dk> wrote: >> * Fix preserve compiler flags set using DEB_* environment >> variables, in langcore.mk. >> Closes: bug#712729. Thanks to Simon Ruderich, Emilio Pozuelo >> Monfort and Markus. > > This change introduces a bug: packages with names that are illegal > shell variable names. For an example, see pulseaudio[1]. This change > results in build flags not being applied. > > > The filter needs to be smarter.Perhaps only exporting the variables > that look like the ones in the buildflags manpage should be exported: > > allvars = $(filter DEB_%,$(.VARIABLES)) > filt = $(foreach suf,APPEND PREPEND SET STRIP OPTIONS,$(filter > %$(suf),_,$(allvars))) > exp = $(foreach flag,$(filt),$(flag)="$($(flag))") > > Please fix this asap, as this change is breaking other packages. > > > [1] > https://buildd.debian.org/status/fetch.php?pkg=pulseaudio&arch=kfreebsd-i386&ver=5.0-11&stamp=1409110310
Could you please elaborate on this - e.g. on the concrete example. Sorry, I looked at that build log but failed to extract what failed and how it relates to the change in CDBS - I do *not* suspect that your findings are wrong, merely that I need it spelled out with bigger letters. Thanks, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
