Hi! Sorry for the delay, I didn't find time to test the encoding setup. The patch was tested against mailx and sendmail in the squeeze archive. I've tested both ENCRYPT_EMAIL set to yes and no, and use yes for my machine.
I suspect if this patch can handle different charset because it only
sends "plain" mail instead of more complex MIME mail. So if the content
is 8-bit clean or the client side can detect the encoding then it's
fine. One big question is I don't know how to tell metche to send
non-ascii content.
>> +add_header() {
>> + local subject="$1";
>> + echo "Subject: $subject";
>> + echo "To: $EMAIL_ADDRESS";
>> + echo
>> + cat;
>> +}
>
> Why the ';' between those commands and at the end of the function
> code? I presume I can safely remove these chars but I'm asking in case
> there is a good reason not to.
the ';'s can be safely removed, just a habit carried from writing C
family languages ;-)
> Also, why is it needed to add the 'To:' header? Isn't it enough to
> pass the recipient address as an argument to sendmail, as done by the
> _mail function you introduce?
To: header in the mail header is essential for sendmail because the
recipient address is only for SMTP protocol (they don't have to be the
same address).
Cheers,
Kanru
pgpwX0XoxaOpU.pgp
Description: PGP signature
