Excerpts from Thibaut Girka's message of Die Aug 17 20:49:41 +0200 2010: > Le mardi 17 août 2010 à 19:56 +0200, Gaudenz Steinlin a écrit : > > (Assuming Martin meant approved upstream.) > > > > While I agree that this patch should also be sent upstream I think > > this is not a feature addition but a bug fix and it's therefore a good > > idea to fix the Debian package. > > Well, it's not really a bugfix, since the bug itself is already fixed > (but unfortunately not in FR's NOR).
OK, I wasn't aware that the bug in uboot is fixed. > > > IMO the fix should not introduce a new command line option but just > > add the correct padding whenever it's necessary. Or is there a chance > > that images without the padding wich are not correctly aligned by pure > > chance will work (better) in some circumstances? > > The current patch does (add a new command line option), but I'm not sure > it is needed (but dropping the option would feel like the past U-Boot > bugs would "define" the format), since modified images should work just > fine, no matter if U-Boot is fixed or not. As the bug is fixed upstream I think a command line option is appropriate. The doc should however mention which versions of uboot need the padding. > > That said, we can drop the patch, and do the padding ourselves before > the mkimage call. I don't like this solution. Like this others affected by the same bug don't get the benefit and it's easier to loose the knowledge why this padding is done at all and running into the bug once again later. Gaudenz -- Ever tried. Ever failed. No matter. Try again. Fail again. Fail better. ~ Samuel Beckett ~
signature.asc
Description: PGP signature
