]] Alan DeKok | Tollef Fog Heen wrote: | > yes, this works around this specific crash. However, must all modules | > be written in a thread-safe fashion? | | Yes.
Ok. | > If so, shouldn't rlm_passwd rather | > be using a mutex to ensure the file pointer isn't accessed from multiple | > threads at the same time? | | Instead, it should make the file pointer local, and not put it in a | global (instance) variable. Ok, fair enough. | > If they're not required to be thread-safe, I'm wondering how the crash could happen. | > | > I'm happy to test that patch for a while, though. | | A better suggestion is to remove the configuration that reads the file | for every packet. FreeRADIUS already supports HUP to re-load files when | they change. And reading a potentially large file for 1000 packets/s is | a *very* bad idea. Please don't do this. I am using freeradius in a (very) low-volume environment where reading a passwd file once a second (maximum) is not a problem at all. Having the tool that updates the passwd file be run as root or be allowed to SIGHUP freeradius would be much more invasive. For those that have 1 kpps, just add caching, which I think is there already? Regards, -- Tollef Fog Heen UNIX is user friendly, it's just picky about who its friends are -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
