Tollef Fog Heen wrote: > yes, this works around this specific crash. However, must all modules > be written in a thread-safe fashion?
Yes. > If so, shouldn't rlm_passwd rather > be using a mutex to ensure the file pointer isn't accessed from multiple > threads at the same time? Instead, it should make the file pointer local, and not put it in a global (instance) variable. > If they're not required to be thread-safe, I'm wondering how the crash could > happen. > > I'm happy to test that patch for a while, though. A better suggestion is to remove the configuration that reads the file for every packet. FreeRADIUS already supports HUP to re-load files when they change. And reading a potentially large file for 1000 packets/s is a *very* bad idea. Alan DeKok. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
