Package: lensfun Version: 0.2.3-2 Severity: wishlist Tags: patch Hi,
thanks for maintaining lensfun. During Ubuntu's rebuild test lensfun failed to build[1] as gcc-4.4/new eglibc changed the definition of strchr, so that it either needs a const char * argument and returns a const char*, or needs a char * argument and returns a char *. I've attached an ugly patch which fixes this. It doesn't address the real problem that my_eval_variable overwrites the const argument though. Cheers, Stefan. [1]: <http://launchpadlibrarian.net/31818250/buildlog_ubuntu-karmic-amd64.lensfun_0.2.3-0ubuntu3_FAILEDTOBUILD.txt.gz> -- System Information: Debian Release: squeeze/sid APT prefers karmic-updates APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic') Architecture: amd64 (x86_64) Kernel: Linux 2.6.31-10-generic (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
#! /bin/sh /usr/share/dpatch/dpatch-run ## 10-makedep-fix-ftbfs.dpatch by Stefan Potyra <sistp...@ubuntu.com> ## ## All lines beginning with `## DP:' are a description of the patch. ## DP: ugly fix for ftbfs. @DPATCH@ diff -urNad lensfun-0.2.3~/tools/makedep/cppsetup.cpp lensfun-0.2.3/tools/makedep/cppsetup.cpp --- lensfun-0.2.3~/tools/makedep/cppsetup.cpp 2007-11-04 00:52:20.000000000 +0100 +++ lensfun-0.2.3/tools/makedep/cppsetup.cpp 2009-09-19 16:20:19.000000000 +0200 @@ -181,7 +181,7 @@ static long my_eval_variable (IfParser *ip, const char *var, int len) { struct symtab **s; - char *eol; + const char *eol; s = lookup_variable (ip, var, len); if (!s) @@ -215,7 +215,7 @@ while (eol > var && isspace (eol [-1])) eol--; - *eol = 0; + *(char *)eol = 0; return strtol (var, NULL, 0); }