On Tue, Sep 15, 2009 at 07:42:57AM +0200, Roland Clobus wrote: > Oops, I was too early when sending the patch. The new attached patch > correctly prepends the commands before the values that need to be > passed on the commandline.
It looks almost good. > -test -z "$PORT_RANGE" || PORT_RANGE="--port-range $PORT_RANGE" > -test -z "$META_SERVER_NAME" || META_SERVER_NAME="`dnsdomainname --fqdn`" > +test "$PORT_RANGE" && PORT_RANGE="--port-range $PORT_RANGE" > +test "$META_SERVER_NAME" && META_SERVER_NAME="--servername $META_SERVER_NAME" However, if test now returns false, the script should abort (it doesn't, because I also forgot to pass the -e option on the first line; good that I see that now.) So I'll use the patch, but with "test -z ... || ...". That means the PORT_RANGE line is not changed, and the META_SERVER_NAME gets the --servername in the variable, as it should. By the way, it wasn't actually wrong; it was just always giving the --servername argument, while the meta-server has logic to determine the right servername itself if none is given. Thanks, Bas
signature.asc
Description: Digital signature
