On Mon, Sep 14, 2009 at 09:29:59PM +0200, Roland Clobus wrote:
> Package: pioneers-console
> Version: 0.12.2-5
> Severity: normal
> File: pioneers
> Tags: patch

> The settings in /etc/default/pioneers-console are not used, because the
> logic in /etc/init.d/pioneers-console is reversed.

> See the attached patch.


> -test -z "$PORT_RANGE" || PORT_RANGE="--port-range $PORT_RANGE"
> -test -z "$META_SERVER_NAME" || META_SERVER_NAME="`dnsdomainname --fqdn`"
> +test "$PORT_RANGE" || PORT_RANGE="--port-range $PORT_RANGE"
> +test "$META_SERVER_NAME" || META_SERVER_NAME="`dnsdomainname --fqdn`"

Er, only the second of these was reversed - the second one has been changed
so that if PORT_RANGE is empty, we pass "--port-range <blank>", which seems
obviously incorrect since it should be given a range as an argument.

Of course, this "port-range" option is *completely undocumented* in the
program --help and the manpage... what gives there? :/

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
[email protected]                                     [email protected]

Attachment: signature.asc
Description: Digital signature

Reply via email to