tag 507760 patch thanks Cyril Brulebois <[EMAIL PROTECTED]> (04/12/2008): > I might have a look at the history between both versions to see what > caused this.
Bleh, huge diff. :) Anyway, first guess was correct, the following (source) debdiff allows me to get the same results as with 1.8.8-3. I'll leave it to you to ask upstream why/whether that code deletion was on purpose/needed for some reasons. :) Cheers, -- Cyril Brulebois
diff -u ipmitool-1.8.9/debian/changelog ipmitool-1.8.9/debian/changelog
--- ipmitool-1.8.9/debian/changelog
+++ ipmitool-1.8.9/debian/changelog
@@ -1,3 +1,11 @@
+ipmitool (1.8.9-2) unstable; urgency=low
+
+ * Make sdr/Temperatures reading working again (Closes: #507760):
+ - Add patch to revert some bits from 1.8.8 to 1.8.9:
+ 20_ipmi_sdr.dpatch
+
+ -- Cyril Brulebois <[EMAIL PROTECTED]> Thu, 04 Dec 2008 11:30:23 +0100
+
ipmitool (1.8.9-1) unstable; urgency=low
* Adopt package (Closes: #432027)
diff -u ipmitool-1.8.9/debian/patches/00list
ipmitool-1.8.9/debian/patches/00list
--- ipmitool-1.8.9/debian/patches/00list
+++ ipmitool-1.8.9/debian/patches/00list
@@ -3,0 +4 @@
+20_ipmi_sdr.dpatch
only in patch2:
unchanged:
--- ipmitool-1.8.9.orig/debian/patches/20_ipmi_sdr.dpatch
+++ ipmitool-1.8.9/debian/patches/20_ipmi_sdr.dpatch
@@ -0,0 +1,24 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 20_ipmi_sdr.dpatch by Cyril Brulebois <[EMAIL PROTECTED]>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Enable reading temperatures again (Closes: #507760).
+
[EMAIL PROTECTED]@
+
+--- a/lib/ipmi_sdr.c
++++ b/lib/ipmi_sdr.c
+@@ -1122,6 +1122,13 @@
+ } else if (IS_SCANNING_DISABLED(rsp->data[1])) {
+ /* Sensor Scanning Disabled */
+ validread = 0;
++ if (rsp->data[0] != 0) {
++ /* we might still get a valid reading */
++ val = sdr_convert_sensor_reading(sensor,
++ rsp->data[0]);
++ if (val != 0.0)
++ validread = 1;
++ }
+ } else if (rsp->data[0] != 0) {
+ /* convert RAW reading into units */
+ val = sdr_convert_sensor_reading(sensor, rsp->data[0]);
signature.asc
Description: Digital signature
