On Tue, Aug 26, 2008 at 10:48:37AM +0930, Arthur Marsh wrote:
> Setting up grub-pc (1.96+20080724-8) ...
> error: cannot open `(null)'
It seems there are 3 places in which the same message could be issued.
Please try the attached patch (in addition to the last one). It should make
them distinguishable so we can find which one you hit.
Thank you
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
Index: util/biosdisk.c
===================================================================
--- util/biosdisk.c (revision 1828)
+++ util/biosdisk.c (working copy)
@@ -164,7 +164,7 @@ grub_util_biosdisk_open (const char *nam
fd = open (map[drive].device, O_RDONLY);
if (fd == -1)
- return grub_error (GRUB_ERR_BAD_DEVICE, "cannot open `%s'", map[drive].device);
+ return grub_error (GRUB_ERR_BAD_DEVICE, "cannot open `%s' while attempting to get disk size", map[drive].device);
if (fstat (fd, &st) < 0 || ! S_ISBLK (st.st_mode))
{
@@ -288,7 +288,7 @@ open_device (const grub_disk_t disk, gru
is_partition = linux_find_partition (dev, disk->partition->start);
/* Open the partition. */
- grub_util_info ("opening the device `%s'", dev);
+ grub_util_info ("opening the device `%s' in open_device()", dev);
fd = open (dev, flags);
if (fd < 0)
{
@@ -306,7 +306,7 @@ open_device (const grub_disk_t disk, gru
fd = open (map[disk->id].device, flags);
if (fd < 0)
{
- grub_error (GRUB_ERR_BAD_DEVICE, "cannot open `%s'", map[disk->id].device);
+ grub_error (GRUB_ERR_BAD_DEVICE, "cannot open `%s' in open_device()", map[disk->id].device);
return -1;
}
#endif /* ! __linux__ */
@@ -835,7 +835,7 @@ grub_util_biosdisk_get_grub_dev (const c
fd = open (os_dev, O_RDONLY);
if (fd == -1)
{
- grub_error (GRUB_ERR_BAD_DEVICE, "cannot open `%s'", os_dev);
+ grub_error (GRUB_ERR_BAD_DEVICE, "cannot open `%s' while attempting to get disk geometry", os_dev);
free (name);
return 0;
}
