Bug#305020: /etc/uif/uif.conf in the /etc/init.d/uif startup script

[Cajus Pollmeier]

I can't see a bug out there...

Am 17.04.2005 um 11:35 schrieb Cristian Ionescu-Idbohrn:

Package: uif
Version: 1.0.5-3
Severity: normal
Tags: patch

Please consider all or parts of this:

---8<---
--- uif.orig    2005-04-17 11:13:01.000000000 +0200
+++ uif 2005-04-17 11:20:26.000000000 +0200
@@ -11,13 +11,18 @@

 PATH=/usr/sbin:/sbin:$PATH
 UIF=/usr/sbin/uif
+CONF=/etc/uif/uif.conf

 # Include firewall defaults if available
-if [ -f /etc/default/uif ] ; then
-       . /etc/default/uif
-fi
+[ -f /etc/default/uif ] && . /etc/default/uif
+
+# Is there a conf file?
+[ -f $CONF ] || {
+       echo "some appropriate error message goes here"
+       exit 1
+}

-[ -z "$OPTIONS" ] && OPTIONS="-c /etc/uif/uif.conf"
+[ -z "$OPTIONS" ] && OPTIONS="-c $CONF"

 # Binaries installed?
 if [ ! -f /sbin/iptables ]; then
@@ -32,11 +37,11 @@ fi
 # As the name says. If the kernel supports modules, it'll try to load
 # the ones listed in "MODULES".
 load_modules() {
-       [ -f /proc/modules ] || return
+       [ -f /proc/modules ] || return 0
         LIST=`/sbin/lsmod|awk '!/Module/ {print $1}'`

         for mod in $MODULES; do
-            echo $LIST | grep -q $mod || modprobe $mod || /bin/true
+            echo $LIST | grep -q $mod || modprobe $mod || :
         done
 }

@@ -58,7 +63,7 @@ start)
         echo "failed. Old rules have been restored."
        logger "Starting uif failed: $EMSG"

- [ -n "$MAILTO" ] && \
+ [ -n "$MAILTO" ] &&
echo -e "Hi. This is your firewall script - which has failed" \
"to execute in a proper way.\nHere is the error message:\n" \
"\n$EMSG\n\nPlease fix to be sure..." | mail -s "Firewall script failure" $MAILTO
---8<---

(the file needs some whitespace cleening too)

Cheers,
Cristian

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.27
Locale: LANG=C, LC_CTYPE= (charmap=ANSI_X3.4-1968)

Versions of packages uif depends on:
ii bsdutils 1:2.12p-4 Basic utilities from 4.4BSD-Lite
ii debconf [debconf-2.0] 1.4.48 Debian configuration management sy
ii iptables 1.2.11-10 Linux kernel 2.4+ iptables adminis
ii libnet-ldap-perl 0.3202-3 A Client interface to LDAP servers
ii libnetaddr-ip-perl 3.14-2 Manipulate IP Addresses easily
ii perl 5.8.4-8 Larry Wall's Practical Extraction

-- debconf information:
* uif/conf_method: don't touch
  uif/trusted:
  uif/traceroute: true
  uif/workstation:
  uif/pings: true
  uif/error:

--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]