On Mon, Mar 12, 2007 at 12:44:35PM +0800, Thomas Goirand wrote:
> Pierre Habouzit wrote:
> > Package: dtc
> > Severity: grave
> > Justification: renders package unusable
> >   in the debian_config script you can find oddities like:

> >     if [ ""$conf_use_nated_vhosts = "true" -o ""$conf_use_nated_vhosts = 
> > "yes" ] ; then 

> >   or

> >     if [ ""$RET = "true" -o ""$RET = "yes" ] ; then 

> >   Please learn proper quoting in sh scripting. sh(1) could be a good
> > start.

> The goal was NOT to quote in this case, but to have the script work if
> the variable is empty. This does what it was meant to do.

> After knowing that, do you still think it's wrong?

It's wrong if there's any chance that any of these variables will contain
values with embedded spaces.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
[EMAIL PROTECTED]                                   http://www.debian.org/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to