severity 414478 grave thanks > On Mon, Mar 12, 2007 at 12:49:25AM +0100, Pierre Habouzit wrote: > > Package: dtc > > Severity: grave > > Justification: renders package unusable > > > > > > in the debian_config script you can find oddities like: > > > > if [ ""$conf_use_nated_vhosts = "true" -o ""$conf_use_nated_vhosts = > > "yes" ] ; then > > > > or > > > > if [ ""$RET = "true" -o ""$RET = "yes" ] ; then > > > > Please learn proper quoting in sh scripting. sh(1) could be a good > > start. > > Ok, I read too fast here, and was confused. The code is correct, it's > just _so_ unusual that I first thought it was a bug. > > please rather use "$foo" than ""$foo or $foo"" it's _really_ hard to > read, and do remember code is written to be read too ;)
I'm on crack, I remember why it does not works: ""$foo is not the same as "$foo" if $foo as spaces in it. Here you take variables from debconf, and it's possible that the user put spaces in it, for many of the cases. Hence ""$foo will fail miserably with some "unable to find `bar'"-like messages. it make the installation fail, hence it's RC. Please do fix your quoting. Also consider that you sometimes forget to quote some tests and if $foo is empty [ $foo -eq 2 ] will fail as well because [ will miss an argument before -eq. re-raising accordingly. -- ·O· Pierre Habouzit ··O [EMAIL PROTECTED] OOO http://www.madism.org
pgpqwsZRxw4Kl.pgp
Description: PGP signature
