Hi,
On Sun, Feb 11, 2007, Nico Golde wrote:
> - fd = open(filename, O_RDWR);
> + if((fd = open(filename, O_RDWR))<0){
Ok, one check for open().
> - key = atoi(argv[1]);
> + key = strtol(argv[1], NULL, 10);
Ok.
> - return 1;
> + return -1;
Not sure about -1.
> -TPSTATUS=`synclient -l | grep TouchpadOff | awk '{print $3}'`
> +TPSTATUS=`synclient -l | awk '{/TouchpadOff/ print $3}'`
You want awk '/TouchpadOff/ { print $3}'; I applied that to the SVN.
> -state=`. /etc/acpi/wireless.sh`
> +state=$((`cat /proc/acpi/asus/wled`)
Not sure it's a good idea.
> -4
> +5
Didn't see the corresponding debian/control change. :)
I switched to compatibility level 5 in SVN though, thanks.
> -. /usr/share/acpi-support/key-constants
> -acpi_fakekey $KEY_WWW
> +sensible-browser &
Not sure this is a good idea either.
So, thanks for the patches, but I am not too motivated to apply them:
- I don't feel any real life bug is being fixed
- increases the diff with upstream (Ubuntu)
- not too sure about the rationale for some changes you did since I am
not sure I understand the architecture / design decisions in
acpi-support
Could you send the remaining fixes as diff -w patches directly to
upstream? I can forward them if you prefer so.
Bye,
--
Loïc Minier <[EMAIL PROTECTED]>
