Hi, * Loïc Minier <[EMAIL PROTECTED]> [2007-02-11 21:04]: > On Sun, Feb 11, 2007, Nico Golde wrote: > > - return 1; > > + return -1; > > Not sure about -1.
1 means success on VMS for example, just thought -1 is more
portable. But you can also consider to return EXIT_FAILURE
> > -TPSTATUS=`synclient -l | grep TouchpadOff | awk '{print $3}'`
> > +TPSTATUS=`synclient -l | awk '{/TouchpadOff/ print $3}'`
>
> You want awk '/TouchpadOff/ { print $3}'; I applied that to the SVN.
Yeah, grep is just not needed here.
> > -state=`. /etc/acpi/wireless.sh`
> > +state=$((`cat /proc/acpi/asus/wled`)
>
> Not sure it's a good idea.
Ok keep the old, just thought it might be a simplification,
of course this could cause the led switched on if someone
manually changes the value in wled.
> > -4
> > +5
>
> Didn't see the corresponding debian/control change. :)
Thanks forgot.
> > -. /usr/share/acpi-support/key-constants
> > -acpi_fakekey $KEY_WWW
> > +sensible-browser &
>
> Not sure this is a good idea either.
Why not? acpi_fakekey needs a working acpi implementation
supported by hardware. So if the hardware support for ACPI
is broken nothing will happen (for example on my notebook).
But the call of sensible-browser won't do any assumption
about the environment.
> So, thanks for the patches, but I am not too motivated to apply them:
> - I don't feel any real life bug is being fixed
Yes true, just cleanups
> - increases the diff with upstream (Ubuntu)
Ok
> - not too sure about the rationale for some changes you did since I am
> not sure I understand the architecture / design decisions in
> acpi-support
>
> Could you send the remaining fixes as diff -w patches directly to
> upstream? I can forward them if you prefer so.
Feel free to forward :)
Kind regards
Nico
--
Nico Golde - http://www.ngolde.de
JAB: [EMAIL PROTECTED] - GPG: 0x73647CFF
Forget about that mouse with 3/4/5 buttons,
gimme a keyboard with 103/104/105 keys!
pgp9ESMinm4VH.pgp
Description: PGP signature
