Goswin von Brederlow wrote:
> Bob Proulx writes:
> Ok, gzip -dc used now.

Thanks for humoring me.

> I check for a failure of the system call too but that only tells me
> that patch failed. In verbose mode it will report the failure but not
> count it as error since it will just fetch the full file then. This
> allows using debmirror without patch installed if anyone wants
> that.

I think that is fine.  In verbose mode report the failure and correct
with a full file fetch.  In normal (non-verbose) mode no need to
report anything.  That sounds good.

> The drawback is that any actual patch failures will just be silently
> corrected without indicating a problem.

I misunderstand because this with the previous sentence seems to be
opposite statements.  I am sorry that I am not understanding here on
this very small point.

If something that should not be failing is failing then I don't like
to see it be completely silent.  Okay to be silent in the normal
non-verbose mode.  But when verbose is active I think errors that
should not happen but did fail be reported that they did fail even
though the workaround corrects it immediately.  Because I have seen
times when those impossible situations did arise and having that
information during debugging was invaluable.  And sometimes in my own
programs I have later created that impossible situation breaking the
feature permanently.  The message informing me of it let me know about
the problem easily when otherwise I would have been silently
correcting and losing the benefit of the feature.

I have raised my issues and you have given it thought and I will
support whatever you decide to do here.  Thanks again for all of the
hard work maintaining this package!  I use it every day and it helps
me out very much.

Bob


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to