Debian Bug Tracking System napisał(a):
> This is an automatic notification regarding your Bug report
> #261274: bchunk: gets track size wrong,
> which was filed against the bchunk package.
> 
> It has been closed by Daniel Baumann <[EMAIL PROTECTED]>.
> 
> Their explanation is attached below.  If this explanation is
> unsatisfactory and you have not received a better one in a separate
> message then please contact Daniel Baumann <[EMAIL PROTECTED]> by replying
> to this email.
> 
> Debian bug tracking system administrator
> (administrator, Debian Bugs database)
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Temat:
> Bug#261274: fixed in bchunk 1.2.0-3
> Od:
> Daniel Baumann <[EMAIL PROTECTED]>
> Data:
> Fri, 08 Sep 2006 06:02:05 -0700
> Do:
> [EMAIL PROTECTED]
> 
> Do:
> [EMAIL PROTECTED]
> 
> Received:
> (at 261274-close) by bugs.debian.org; 8 Sep 2006 13:03:21 +0000
> Return-path:
> <[EMAIL PROTECTED]>
> Received:
> from dak by spohr.debian.org with local (Exim 4.50) id 1GLfzh-0003gh-9H;
> Fri, 08 Sep 2006 06:02:05 -0700
> X-DAK:
> dak process-unchecked
> X-Katie:
> $Revision: 1.65 $
> Identyfikator wiadomości:
> <[EMAIL PROTECTED]>
> Nadawca:
> Archive Administrator <[EMAIL PROTECTED]>
> X-Spam-Checker-Version:
> SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on
> spohr.debian.org
> X-Spam-Status:
> No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER autolearn=no
> version=2.60-bugs.debian.org_2005_01_02
> 
> 
> Source: bchunk
> Source-Version: 1.2.0-3
> 
> We believe that the bug you reported is fixed in the latest version of
> bchunk, which is due to be installed in the Debian FTP archive:
> 
> bchunk_1.2.0-3.diff.gz
>   to pool/main/b/bchunk/bchunk_1.2.0-3.diff.gz
> bchunk_1.2.0-3.dsc
>   to pool/main/b/bchunk/bchunk_1.2.0-3.dsc
> bchunk_1.2.0-3_i386.deb
>   to pool/main/b/bchunk/bchunk_1.2.0-3_i386.deb
> 
> 
> 
> A summary of the changes between this version and the previous one is
> attached.
> 
> Thank you for reporting the bug, which will now be closed.  If you
> have further comments please address them to [EMAIL PROTECTED],
> and the maintainer will reopen the bug report if appropriate.
> 
> Debian distribution maintenance software
> pp.
> Daniel Baumann <[EMAIL PROTECTED]> (supplier of updated bchunk package)
> 
> (This message was generated automatically at their request; if you
> believe that there is a problem with it please contact the archive
> administrators by mailing [EMAIL PROTECTED])
> 
> 
> Format: 1.7
> Date: Fri,  8 Sep 2006 14:45:00 +0200
> Source: bchunk
> Binary: bchunk
> Architecture: source i386
> Version: 1.2.0-3
> Distribution: unstable
> Urgency: low
> Maintainer: Daniel Baumann <[EMAIL PROTECTED]>
> Changed-By: Daniel Baumann <[EMAIL PROTECTED]>
> Description: 
>  bchunk     - CD image format conversion from bin/cue to iso/cdr
> Closes: 261274
> Changes: 
>  bchunk (1.2.0-3) unstable; urgency=low
>  .
>    * Added 01-track-size.dpatch from Piotr Kaczuba <[EMAIL PROTECTED]> to fix
>      wrong track size calculation when having multiple tracks in one image
>      (Closes: #261274).
> Files: 
>  5c70abd077b6cc5f7dcafc88fc75fd6c 561 otherosfs optional bchunk_1.2.0-3.dsc
>  c5ff50c85f01709d2c77bdccdcd05077 3040 otherosfs optional 
> bchunk_1.2.0-3.diff.gz
>  22cf3007e01c6477599c89ef838d97b9 13468 otherosfs optional 
> bchunk_1.2.0-3_i386.deb
> 

Attached is a simpler fix for the problem. The new patch corrects the
bug at the root cause, which is IMHO more elegant. You might consider
applying it instead of the previous patch I sent.

Piotr Kaczuba
Tylko w bchunk-1.2.0.new/: bchunk
diff -ru bchunk-1.2.0/bchunk.c bchunk-1.2.0.new/bchunk.c
--- bchunk-1.2.0/bchunk.c       2004-06-29 22:42:33.000000000 +0200
+++ bchunk-1.2.0.new/bchunk.c   2006-09-08 17:57:30.106053763 +0200
@@ -476,7 +476,7 @@
                        if (verbose)
                                printf(" (startsect %ld ofs %ld)", 
track->startsect, track->start);
                        if ((prevtrack) && (prevtrack->stopsect < 0)) {
-                               prevtrack->stopsect = track->startsect;
+                               prevtrack->stopsect = track->startsect - 1;
                                prevtrack->stop = track->start - 1;
                        }
                }
@@ -484,7 +484,7 @@
        
        if (track) {
                fseek(binf, 0, SEEK_END);
-               track->stop = ftell(binf);
+               track->stop = ftell(binf) - 1;
                track->stopsect = track->stop / SECTLEN;
        }
        

Reply via email to