Control: tags 1107155 + patch

On Mon 2025-06-02 13:20:52 +0000, Holger Levsen wrote:
> "sqv | sqopv | rsopv | sopv | gosop | pgpainless-cli | gpgv-sq | gpgv"
> taken from dpkg-dev.

I don't think this is quite right, holger, since devscripts doesn't know
how to handle either "sqv" or "gpgv-sq".

Ideally, devscripts wouldn't be the package to make this decision, but
for the sake of predictability the patch below might be useful.

    --dkg

From 9a726f7914ac4952be38d9909e4adbe5c56727e2 Mon Sep 17 00:00:00 2001
From: Daniel Kahn Gillmor <[email protected]>
Date: Mon, 2 Jun 2025 12:23:22 -0400
Subject: [PATCH] Specify specific sopv implementations (Closes: #1107155)

This is a stopgap measure.

For OpenPGP signature verification, prefer specific implementations of
the Stateless OpenPGP Verification subset rather than just the generic
"sopv" variant.  This should make package installation somewhat more
predictable.

In the long run, it would be nice to not hard-code this specific
preference list, and just let the system default OpenPGP verifier work
as planned.

There is at least one other SOPV implementation available in debian,
which is sopv-gpgv, but given that devscripts seems to think it knows
how to talk to gpgv directly, and sopv-gpgv just depends on gpgv
anyway, we don't bother listing that one here.

Other implemetations are very close to implementing
sopv (e.g. pgpainless-cli, see
https://github.com/pgpainless/pgpainless/issues/445 ) and it would be
a shame to have to maintain this list in devscripts's dependency list
over the the long term.
---
 debian/control | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index 510537c7..f0c6d6b4 100644
--- a/debian/control
+++ b/debian/control
@@ -58,7 +58,7 @@ Build-Depends:
  python3-unidiff <!nocheck>,
  python3-xdg <!nocheck>,
  shunit2 <!nocheck>,
- sopv <!nocheck> | gpgv <!nocheck>,
+ sqopv <!nocheck> | rsopv <!nocheck> | gosop <!nocheck> | sopv <!nocheck> | gpgv <!nocheck>,
  subversion [!i386] <!nocheck>,
  unzip <!nocheck>,
  wdiff <!nocheck>,
@@ -87,7 +87,7 @@ Depends:
  libwww-perl,
  patchutils,
  sensible-utils,
- sopv | gpgv,
+ sqopv | rsopv | gosop | sopv | gpgv,
  wdiff,
  ${misc:Depends},
  ${perl:Depends},
-- 
2.47.2

Reply via email to