Control: tags -1 pending

Hi!

Thanks for the patch, I will apply it ASAP.

On Wed, Feb 19, 2025 at 01:00:26AM +0800, Bo YU wrote:
> Source: python-cassandra-driver
> Version: 3.29.2-4
> Severity: serious
> Tags: ftbfs patch
> User: debian-ri...@lists.debian.org
> Usertags: riscv64
> X-Debbugs-Cc: debian-ri...@lists.debian.org
> 
> Dear Maintainer,
> 
> Now python-cassandra-driver has one FTBFS issue due to test failed:
> 
> ```
> =================================== FAILURES 
> ===================================
> __________________ StrategiesTest.test_nts_token_performance 
> ___________________
> 
> self = <tests.unit.test_metadata.StrategiesTest 
> testMethod=test_nts_token_performance>
> 
>     def test_nts_token_performance(self):
>         """
>    [...] 
>         nts = NetworkTopologyStrategy({'dc1': 3})
>         start_time = timeit.default_timer()
>         nts.make_token_replica_map(token_to_host_owner, ring)
>         elapsed_base = timeit.default_timer() - start_time
>     
>         nts = NetworkTopologyStrategy({'dc1': 1500})
>         start_time = timeit.default_timer()
>         nts.make_token_replica_map(token_to_host_owner, ring)
>         elapsed_bad = timeit.default_timer() - start_time
>         difference = elapsed_bad - elapsed_base
> >       self.assertTrue(difference < 1 and difference > -1)
> E       AssertionError: False is not true
> 
> ```
> 
> See 
> https://buildd.debian.org/status/fetch.php?pkg=python-cassandra-driver&arch=riscv64&ver=3.29.2-4&stamp=1739528871&raw=0
> 
> The code show me that there is a high probability that it is still because of
> the timeout problem in riscv64, so I increase the difference range on
> riscv64 to pass the test and this works on my Unmatched boards.
> 
> Could you apply this on the next upload? Or let me know any issue
> please.
> 
> -- 
> Regards,
> --
>   Bo YU
> 

> diff -Nru python-cassandra-driver-3.29.2/debian/changelog 
> python-cassandra-driver-3.29.2/debian/changelog
> --- python-cassandra-driver-3.29.2/debian/changelog   2025-02-13 
> 13:14:59.000000000 +0000
> +++ python-cassandra-driver-3.29.2/debian/changelog   2025-02-18 
> 16:21:22.000000000 +0000
> @@ -1,3 +1,11 @@
> +python-cassandra-driver (3.29.2-4.1) UNRELEASED; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Increase difference range to pass test_nts_token_performance test on
> +    riscv64. (Closes: #-1)
> +
> + -- Bo YU <vi...@debian.org>  Tue, 18 Feb 2025 16:21:22 +0000
> +
>  python-cassandra-driver (3.29.2-4) unstable; urgency=medium
>  
>    * Fix the build of cassandra.io.libevwrapper extension on Python 3.13
> diff -Nru 
> python-cassandra-driver-3.29.2/debian/patches/0008-Increase-difference-on-rv64.patch
>  
> python-cassandra-driver-3.29.2/debian/patches/0008-Increase-difference-on-rv64.patch
> --- 
> python-cassandra-driver-3.29.2/debian/patches/0008-Increase-difference-on-rv64.patch
>       1970-01-01 00:00:00.000000000 +0000
> +++ 
> python-cassandra-driver-3.29.2/debian/patches/0008-Increase-difference-on-rv64.patch
>       2025-02-18 16:21:22.000000000 +0000
> @@ -0,0 +1,31 @@
> +Description: increase the difference range on riscv64
> + workaround on riscv64 because it is slow at this moment 
> +Author: Bo YU <vi...@debian.org>
> +Bug: 
> https://buildd.debian.org/status/fetch.php?pkg=python-cassandra-driver&arch=riscv64&ver=3.29.2-4&stamp=1739528871&raw=0
> +Last-Update: 2025-02-18
> +---
> +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
> +Index: b/tests/unit/test_metadata.py
> +===================================================================
> +--- a/tests/unit/test_metadata.py
> ++++ b/tests/unit/test_metadata.py
> +@@ -18,6 +18,7 @@
> + from unittest.mock import Mock
> + import os
> + import timeit
> ++import platform
> + 
> + import cassandra
> + from cassandra.cqltypes import strip_frozen
> +@@ -268,7 +269,10 @@
> +         nts.make_token_replica_map(token_to_host_owner, ring)
> +         elapsed_bad = timeit.default_timer() - start_time
> +         difference = elapsed_bad - elapsed_base
> +-        self.assertTrue(difference < 1 and difference > -1)
> ++        if platform.machine() == 'riscv64':
> ++            self.assertTrue(difference < 2 and difference > -2)
> ++        else:
> ++            self.assertTrue(difference < 1 and difference > -1)
> + 
> +     def test_nts_make_token_replica_map_multi_rack(self):
> +         token_to_host_owner = {}
> diff -Nru python-cassandra-driver-3.29.2/debian/patches/series 
> python-cassandra-driver-3.29.2/debian/patches/series
> --- python-cassandra-driver-3.29.2/debian/patches/series      2025-02-13 
> 13:14:59.000000000 +0000
> +++ python-cassandra-driver-3.29.2/debian/patches/series      2025-02-18 
> 07:25:26.000000000 +0000
> @@ -1,3 +1,4 @@
> +0008-Increase-difference-on-rv64.patch
>  Make_unittests_loadable.patch
>  Disable_GitHub_links_in_doc.patch
>  0003-Skip-tests-that-fails-on-i386-arch.patch




-- 
cheers,
        Emmanuel Arias

 ?????????????????????
 ?????????????????????  eam...@debian.org
 ?????????????????????  OpenPGP: 13796755BBC72BB8ABE2AEB5 FA9DEC5DE11C63F1      
               
 ?????????

Attachment: signature.asc
Description: PGP signature

Reply via email to