On Wed, Feb 12, 2025 at 01:58:25PM -0500, Nicolas Mora wrote: > Hello Ben, > > Thank you for preparing a new package for libjwt 3.0!
Thanks for reviewing the package! > After reviewing and testing your package with sbuild, I have a few > feedbacks: > > - cmake is missing in Build-Depends in debian/control > - Standards-Version in debian/control should be 4.7.0 > - the file debian/copyright is incomplete I've made these changes. > - doxygen version required is 1.12 in the CMakeList.txt, but the version > installed in debian/unstable is 1.9.8, wich makes the cmake script ignore > doxygen, therefore the rest of the build fails since there is no > documentation generated in usr/share/doc/LibJWT/html, and no manpages too. > If I change the doxygen version requirement in the cmake script, the build > passes but doxygen generates a lot of warnings such as: Things look "ok" with 1.9.8. Lintian definitely spews a lot of warnings on the manpages that did not happen with doxygen 1.13.1 (that I had on my system). The output looks fine, so likely acceptable for now. > Also, is it possible to add the packaged version in the Debian Salsa > repository: https://salsa.debian.org/ ? > It would mean 2 different repos to maintain but I recommended debian > packages to be in salsa, because (but not only) salsa has built-in gitlab > scripts to test the package with lots of use cases: build, reproducibility, > autopkgtests, etc. See > https://salsa.debian.org/debian-iot-team/oauth2/libjwt/-/pipelines/767178 > for example. I plan to move to that for the packaging when I get some time. Thanks again -- Ben Collins https://libjwt.io https://github.com/benmcollins -- 3EC9 7598 1672 961A 1139 173A 5D5A 57C7 242B 22CF
signature.asc
Description: PGP signature
