Hello Ben,
Thank you for preparing a new package for libjwt 3.0!
After reviewing and testing your package with sbuild, I have a few
feedbacks:
- cmake is missing in Build-Depends in debian/control
- Standards-Version in debian/control should be 4.7.0
- the file debian/copyright is incomplete
- the following entry has no persona:
Files: *
Copyright: 2015-2025
License: MPL-2.0
- the entry Files: libjwt/gnutls/sign-verify.c mentions Ben Collins
<bcoll...@libjwt.io> but the file itself mentions maClara, LLC
<i...@maclara-llc.com>
- doxygen version required is 1.12 in the CMakeList.txt, but the version
installed in debian/unstable is 1.9.8, wich makes the cmake script
ignore doxygen, therefore the rest of the build fails since there is no
documentation generated in usr/share/doc/LibJWT/html, and no manpages too.
If I change the doxygen version requirement in the cmake script, the
build passes but doxygen generates a lot of warnings such as:
doxygen/DoxygenLayout.xml:8: warning: the type 'topics' is not supported
for the entry tag within a navindex! Check your layout file!
Also, is it possible to add the packaged version in the Debian Salsa
repository: https://salsa.debian.org/ ?
It would mean 2 different repos to maintain but I recommended debian
packages to be in salsa, because (but not only) salsa has built-in
gitlab scripts to test the package with lots of use cases: build,
reproducibility, autopkgtests, etc. See
https://salsa.debian.org/debian-iot-team/oauth2/libjwt/-/pipelines/767178
for example.
/Nicolas
